Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operator Generate again #519

Closed
wants to merge 1 commit into from
Closed

Conversation

akarnokd
Copy link
Member

Issue #49

  • Updated tests to use TestScheduler
  • Removed class TimeSpan and the timeSelectors are expected to return a nanosecond-resolution value.

@cloudbees-pull-request-builder

RxJava-pull-requests #447 SUCCESS
This pull request looks good

@zsxwing
Copy link
Member

zsxwing commented Nov 25, 2013

A small tip about github: You can continue to push any commits to your remote branch. The pull request will be updated automatically.

If you find some conflicts between your remote branch and your local branch, you can use --force to override your remote branch by force. Github will keep the pull request consistent with your remote branch. I think it's better than opening another pull request.

@akarnokd
Copy link
Member Author

@zsxwing I know; my very first pull was such but I received the tip to use clean branches, especially when the master changes above me.

@zsxwing
Copy link
Member

zsxwing commented Nov 25, 2013

Do you mean #509 (comment) ? I think @benjchristensen was suggesting git rebase.

@zsxwing
Copy link
Member

zsxwing commented Nov 25, 2013

In addition, if it's hard to rebase it on master, I also think a new pull request is good.

@benjchristensen
Copy link
Member

Removed class TimeSpan and the timeSelectors are expected to return a nanosecond-resolution value.

We need to support long delayTime, TimeUnit unit as discussed at:#509 (comment)

@akarnokd akarnokd mentioned this pull request Dec 18, 2013
53 tasks
@akarnokd akarnokd deleted the Generate3 branch January 13, 2014 10:04
jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants