2.x: Fix wrong comments in Functions.java “Function3” -> “BiFunction” #5230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.x #5230 +/- ##
============================================
- Coverage 96.02% 96.01% -0.01%
- Complexity 5745 5752 +7
============================================
Files 628 628
Lines 41074 41074
Branches 5697 5697
============================================
- Hits 39443 39439 -4
+ Misses 655 651 -4
- Partials 976 984 +8
Continue to review full report at Codecov.
|
|
I also added fail test case toFunction about Functions.java |
Fix interface naming
akarnokd
requested changes
Mar 26, 2017
| @@ -24,7 +24,7 @@ | |||
| import io.reactivex.schedulers.Timed; | |||
|
|
|||
| /** | |||
| * Utility methods to convert the Function3..Function9 instances to Function of Object array. | |||
| * Utility methods to convert the BiFunction..Function9 instances to Function of Object array. | |||
There was a problem hiding this comment.
Actually, BiFunction, Function3..Function9 would be better.
| @@ -169,6 +169,54 @@ public Integer apply(Integer t1, Integer t2, Integer t3, Integer t4, Integer t5, | |||
| }).apply(new Object[20]); | |||
| } | |||
|
|
|||
| @Test(expected = NullPointerException.class) | |||
| public void biFunctionFail() throws Exception { | |||
There was a problem hiding this comment.
Please add @SuppressWarnings({"unchecked", "rawtypes"}) to all these new methods.
There was a problem hiding this comment.
Thank you for comment.
akarnokd
approved these changes
Mar 26, 2017
akarnokd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using this library in my company(KakaoBank in Korea) and interested in this library.. so I read whole code these days. I feel really thanks for all people who make awesome library and I just wanted to contribute this library.