Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Single.subscribe(BiConsumer) consistent isDisposed #5277

Merged
merged 1 commit into from Apr 10, 2017

Conversation

akarnokd
Copy link
Member

Fixes the Single.subscribe(BiConsumer) to report isDisposed when terminating.

Reported in #5276.

@akarnokd akarnokd added this to the 2.0 backlog milestone Apr 10, 2017
@codecov
Copy link

codecov bot commented Apr 10, 2017

Codecov Report

Merging #5277 into 2.x will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5277      +/-   ##
============================================
+ Coverage     96.02%   96.11%   +0.08%     
- Complexity     5752     5754       +2     
============================================
  Files           628      628              
  Lines         41077    41079       +2     
  Branches       5699     5699              
============================================
+ Hits          39445    39482      +37     
+ Misses          658      627      -31     
+ Partials        974      970       -4
Impacted Files Coverage Δ Complexity Δ
...x/internal/observers/BiConsumerSingleObserver.java 100% <100%> (ø) 7 <2> (ø) ⬇️
...nternal/operators/observable/ObservableCreate.java 91.96% <0%> (-7.15%) 2% <0%> (ø)
.../operators/completable/CompletableConcatArray.java 93.75% <0%> (-6.25%) 2% <0%> (ø)
...reactivex/internal/operators/maybe/MaybeUsing.java 95.95% <0%> (-4.05%) 4% <0%> (ø)
...nternal/operators/parallel/ParallelSortedJoin.java 91.3% <0%> (-3.63%) 2% <0%> (ø)
...al/operators/observable/ObservableSampleTimed.java 93.33% <0%> (-3.34%) 3% <0%> (ø)
...rnal/operators/flowable/FlowableFlatMapSingle.java 93.4% <0%> (-2.75%) 2% <0%> (ø)
...rnal/operators/flowable/FlowableSequenceEqual.java 96.34% <0%> (-2.44%) 2% <0%> (ø)
.../internal/operators/maybe/MaybeTakeUntilMaybe.java 97.95% <0%> (-2.05%) 2% <0%> (ø)
...activex/internal/disposables/DisposableHelper.java 98.14% <0%> (-1.86%) 27% <0%> (-1%)
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80d9b90...445d93c. Read the comment docs.

@akarnokd akarnokd merged commit 8a78c74 into ReactiveX:2.x Apr 10, 2017
@akarnokd akarnokd deleted the SingleBiConsume branch April 10, 2017 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants