Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: make withLatestFrom conditional subscriber, test cold consumption #5495

Merged
merged 2 commits into from Jul 18, 2017

Conversation

akarnokd
Copy link
Member

This PR adjusts #5494 by converting the withLatestFrom operators into conditional subscribers and adds unit tests that verify a cold source is consumed fully if there is no event(s) from the other source(s).

(Also there was a missing space before the bracked and the new unit test name had the test prefix.)

@akarnokd akarnokd added this to the 2.2 milestone Jul 18, 2017
@codecov
Copy link

codecov bot commented Jul 18, 2017

Codecov Report

Merging #5495 into 2.x will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5495      +/-   ##
============================================
- Coverage     96.06%   96.03%   -0.03%     
+ Complexity     5807     5800       -7     
============================================
  Files           631      631              
  Lines         41299    41303       +4     
  Branches       5743     5745       +2     
============================================
- Hits          39674    39666       -8     
- Misses          639      649      +10     
- Partials        986      988       +2
Impacted Files Coverage Δ Complexity Δ
...nal/operators/flowable/FlowableWithLatestFrom.java 100% <100%> (ø) 2 <0> (ø) ⬇️
...operators/flowable/FlowableWithLatestFromMany.java 99.24% <100%> (+1.55%) 7 <0> (ø) ⬇️
...nternal/operators/observable/ObservableCreate.java 93.16% <0%> (-5.99%) 2% <0%> (ø)
.../io/reactivex/internal/functions/ObjectHelper.java 94.73% <0%> (-5.27%) 20% <0%> (-1%)
...tivex/internal/observers/FutureSingleObserver.java 94.33% <0%> (-3.78%) 24% <0%> (-1%)
...reactivex/internal/operators/single/SingleAmb.java 96.36% <0%> (-3.64%) 9% <0%> (-1%)
...ternal/operators/observable/ObservablePublish.java 91.22% <0%> (-3.51%) 9% <0%> (ø)
...activex/internal/operators/single/SingleCache.java 97.05% <0%> (-2.95%) 23% <0%> (-1%)
...a/io/reactivex/internal/util/QueueDrainHelper.java 58.86% <0%> (-2.84%) 31% <0%> (-2%)
...activex/internal/observers/QueueDrainObserver.java 61.53% <0%> (-2.57%) 12% <0%> (-1%)
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 340bed9...1563285. Read the comment docs.

@akarnokd akarnokd merged commit 09df08a into ReactiveX:2.x Jul 18, 2017
@akarnokd akarnokd deleted the WithLatestFromAdjustments branch July 18, 2017 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants