Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: More Observable marble fixes (10/18) #5680

Merged
merged 1 commit into from Oct 18, 2017

Conversation

akarnokd
Copy link
Member

Update several Observable marble diagrams. Images can be viewed here.

  • zipIterable
  • ambWith
  • blockingForEach
  • blockingIterable
  • blockingLast
  • blockingLast(T)
  • blockingMostRecent
  • blockingNext
  • blockingSingle
  • blockingSingle(T)
  • cacheWithInitialCapacity

@akarnokd akarnokd added this to the 2.2 milestone Oct 18, 2017
@codecov
Copy link

codecov bot commented Oct 18, 2017

Codecov Report

Merging #5680 into 2.x will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5680      +/-   ##
============================================
- Coverage     96.26%   96.23%   -0.03%     
  Complexity     5814     5814              
============================================
  Files           633      633              
  Lines         41552    41552              
  Branches       5751     5751              
============================================
- Hits          40000    39988      -12     
- Misses          620      625       +5     
- Partials        932      939       +7
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Observable.java 100% <ø> (ø) 508 <0> (ø) ⬇️
.../operators/flowable/FlowableBlockingSubscribe.java 91.89% <0%> (-5.41%) 9% <0%> (-1%)
...l/operators/observable/ObservableFlatMapMaybe.java 89.54% <0%> (-5.23%) 2% <0%> (ø)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 91.78% <0%> (-4.35%) 2% <0%> (ø)
...activex/internal/observers/QueueDrainObserver.java 61.53% <0%> (-2.57%) 12% <0%> (-1%)
.../internal/disposables/ListCompositeDisposable.java 98% <0%> (-2%) 34% <0%> (-1%)
...ex/internal/subscribers/InnerQueuedSubscriber.java 96.07% <0%> (-1.97%) 18% <0%> (-1%)
.../io/reactivex/disposables/CompositeDisposable.java 97.24% <0%> (-1.84%) 39% <0%> (-1%)
...vex/internal/operators/single/SingleTakeUntil.java 93.44% <0%> (-1.64%) 2% <0%> (ø)
...rnal/subscriptions/DeferredScalarSubscription.java 98.46% <0%> (-1.54%) 28% <0%> (-1%)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddd9b67...c9c9be7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants