Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Fix copy-paste errors in SingleSubject JavaDoc #5834

Merged
merged 1 commit into from
Feb 2, 2018

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Feb 2, 2018

The SingleSubject JavaDoc was derived from the MaybeSubject JavaDoc and thus some mentions of onComplete remained in there. This PR fixes copy-paste errors.

@akarnokd akarnokd added this to the 2.2 milestone Feb 2, 2018
@codecov
Copy link

codecov bot commented Feb 2, 2018

Codecov Report

Merging #5834 into 2.x will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5834      +/-   ##
============================================
- Coverage     96.42%   96.35%   -0.07%     
+ Complexity     5816     5814       -2     
============================================
  Files           634      634              
  Lines         41761    41761              
  Branches       5796     5796              
============================================
- Hits          40268    40240      -28     
- Misses          578      593      +15     
- Partials        915      928      +13
Impacted Files Coverage Δ Complexity Δ
...main/java/io/reactivex/subjects/SingleSubject.java 100% <ø> (ø) 38 <0> (ø) ⬇️
...l/operators/observable/ObservableFlatMapMaybe.java 87.58% <0%> (-7.85%) 2% <0%> (ø)
.../operators/completable/CompletableConcatArray.java 93.75% <0%> (-6.25%) 2% <0%> (ø)
.../io/reactivex/internal/functions/ObjectHelper.java 94.73% <0%> (-5.27%) 20% <0%> (-1%)
...nternal/operators/observable/ObservableCreate.java 91.45% <0%> (-5.13%) 2% <0%> (ø)
...ava/io/reactivex/processors/BehaviorProcessor.java 90.13% <0%> (-4.94%) 59% <0%> (-1%)
...ternal/operators/observable/ObservablePublish.java 92.1% <0%> (-4.39%) 10% <0%> (-1%)
...tivex/internal/schedulers/TrampolineScheduler.java 92.3% <0%> (-2.57%) 6% <0%> (ø)
...va/io/reactivex/internal/queue/SpscArrayQueue.java 97.61% <0%> (-2.39%) 22% <0%> (-1%)
...x/internal/operators/flowable/FlowablePublish.java 93.83% <0%> (-1.77%) 10% <0%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fbc44f...7b6b483. Read the comment docs.

@akarnokd akarnokd merged commit d8f6153 into ReactiveX:2.x Feb 2, 2018
@akarnokd akarnokd deleted the SubjectJavaDocFix0202 branch February 2, 2018 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants