Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added nullability annotation for RxJavaPlugins.onCompletableAssembly #5838

Merged

Conversation

afeozzz
Copy link
Contributor

@afeozzz afeozzz commented Feb 3, 2018

Just annotation that didn't exist

@@ -86,6 +86,7 @@
@Nullable
static volatile Function<? super Single, ? extends Single> onSingleAssembly;

@Nullable
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need the @SuppressWarnings("rawtypes") here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completable does not have a type argument.

@codecov
Copy link

codecov bot commented Feb 3, 2018

Codecov Report

Merging #5838 into 2.x will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5838      +/-   ##
============================================
- Coverage     96.39%   96.36%   -0.04%     
- Complexity     5813     5817       +4     
============================================
  Files           634      634              
  Lines         41760    41760              
  Branches       5796     5796              
============================================
- Hits          40256    40240      -16     
- Misses          583      594      +11     
- Partials        921      926       +5
Impacted Files Coverage Δ Complexity Δ
.../main/java/io/reactivex/plugins/RxJavaPlugins.java 100% <ø> (ø) 146 <0> (ø) ⬇️
...ava/io/reactivex/processors/BehaviorProcessor.java 89.23% <0%> (-5.83%) 59% <0%> (ø)
.../io/reactivex/internal/functions/ObjectHelper.java 94.73% <0%> (-5.27%) 20% <0%> (-1%)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 89.37% <0%> (-3.39%) 2% <0%> (ø)
...tivex/internal/schedulers/TrampolineScheduler.java 92.3% <0%> (-2.57%) 6% <0%> (ø)
...ain/java/io/reactivex/subjects/PublishSubject.java 97.8% <0%> (-2.2%) 38% <0%> (-1%)
...perators/single/SingleFlatMapIterableFlowable.java 96.66% <0%> (-1.67%) 2% <0%> (ø)
...ternal/operators/observable/ObservableFlatMap.java 84.53% <0%> (-1.65%) 3% <0%> (ø)
...vex/internal/operators/single/SingleTakeUntil.java 93.44% <0%> (-1.64%) 2% <0%> (ø)
...ernal/operators/flowable/FlowableTimeoutTimed.java 97.56% <0%> (-1.63%) 3% <0%> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e9eb4f...87253ae. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants