2.x: Add Flowable.concatMap{Maybe,Single}{DelayError} operators #5872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.x #5872 +/- ##
============================================
+ Coverage 96.54% 96.57% +0.03%
- Complexity 5862 5885 +23
============================================
Files 647 650 +3
Lines 42766 43156 +390
Branches 5933 5994 +61
============================================
+ Hits 41289 41679 +390
- Misses 568 572 +4
+ Partials 909 905 -4
Continue to review full report at Codecov.
|
vanniktech
approved these changes
Mar 1, 2018
| @@ -7313,6 +7313,362 @@ public final Completable concatMapCompletableDelayError(Function<? super T, ? ex | |||
| return RxJavaPlugins.onAssembly(new FlowableFlattenIterable<T, U>(this, mapper, prefetch)); | |||
| } | |||
|
|
|||
| /** | |||
| * Maps the upstream intems into {@link MaybeSource}s and subscribes to them one after the | |||
| } | ||
|
|
||
| /** | ||
| * Maps the upstream intems into {@link MaybeSource}s and subscribes to them one after the |
vanniktech
approved these changes
Mar 1, 2018
| * <dt><b>Backpressure:</b></dt> | ||
| * <dd>The operator expects the upstream to support backpressure and honors | ||
| * the backpressure from downstream. If this {@code Flowable} violates the rule, the operator will | ||
| * signal a {@code MissingBackpressureException}.</dd> |
There was a problem hiding this comment.
Same in all javadocs below
There was a problem hiding this comment.
Sounds fine with me:
"the operator will signal a MissingBackpressureException."
There was a problem hiding this comment.
wow, sure, my bad, sorry
|
|
||
| /** | ||
| * Maps the upstream items into {@link SingleSource}s and subscribes to them one after the | ||
| * other succeeds or completes, emits their success value if available or terminates immediately if |
There was a problem hiding this comment.
remove "completes"? It's a Single :)
artem-zinnatullin
approved these changes
Mar 1, 2018
| * @since 2.1.11 - experimental | ||
| */ | ||
| @Experimental | ||
| public final class FlowableConcatMapMaybe<T, R> extends Flowable<R> { |
There was a problem hiding this comment.
// We urgently need a CallMe operator so we could have FlowableCallMeMaybe 😸
| import io.reactivex.subjects.MaybeSubject; | ||
| import io.reactivex.subscribers.TestSubscriber; | ||
|
|
||
| public class FlowableConcatMapMaybeTest { |
This was referenced Mar 2, 2018
This was referenced Mar 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds operators that allow concatenating a mapped sequence of
Maybes orSingles, with or without delaying their errors:concatMapMaybe(+1 overload with prefetch)concatMapMaybeDelayError(+2 overloads with error mode and prefetch)concatMapSingle(+1 overload with prefetch)concatMapSingleDelayError(+2 overloads with error mode and prefetch)They are in the same PR as the
Singlevariant's implementation is practically theMaybeimplementation minus theonCompletecase.Their marbles will be updated in a separate PR.
Originally requested in #4853.