Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nullable annotations for blocking methods in Completable #6244

Merged
merged 1 commit into from Oct 12, 2018

Conversation

Oknesif
Copy link
Contributor

@Oknesif Oknesif commented Oct 12, 2018

Just add @nullable annotations to blockingGet() methods in Completable class.

@codecov
Copy link

codecov bot commented Oct 12, 2018

Codecov Report

Merging #6244 into 2.x will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6244      +/-   ##
============================================
+ Coverage     98.25%   98.25%   +<.01%     
- Complexity     6199     6204       +5     
============================================
  Files           667      667              
  Lines         44887    44887              
  Branches       6216     6216              
============================================
+ Hits          44104    44105       +1     
- Misses          243      248       +5     
+ Partials        540      534       -6
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Completable.java 100% <ø> (ø) 117 <0> (ø) ⬇️
...l/operators/observable/ObservableFlatMapMaybe.java 90.19% <0%> (-4.58%) 2% <0%> (ø)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 88.88% <0%> (-3.87%) 2% <0%> (ø)
...ava/io/reactivex/processors/BehaviorProcessor.java 98.2% <0%> (-0.9%) 59% <0%> (-1%)
...nternal/operators/observable/ObservableCreate.java 98.29% <0%> (-0.86%) 2% <0%> (ø)
...ex/internal/operators/flowable/FlowableReplay.java 94.26% <0%> (-0.85%) 20% <0%> (ø)
...x/internal/operators/flowable/FlowableGroupBy.java 95.51% <0%> (-0.57%) 3% <0%> (ø)
...vex/internal/operators/parallel/ParallelRunOn.java 97.1% <0%> (-0.49%) 8% <0%> (ø)
...va/io/reactivex/processors/MulticastProcessor.java 98.23% <0%> (-0.45%) 83% <0%> (-1%)
...main/java/io/reactivex/subjects/ReplaySubject.java 97.69% <0%> (-0.21%) 50% <0%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17f6e84...bb5cd82. Read the comment docs.

@akarnokd akarnokd added this to the 2.2 backlog milestone Oct 12, 2018
@akarnokd akarnokd merged commit a1758c4 into ReactiveX:2.x Oct 12, 2018
@Oknesif Oknesif deleted the nullable_for_blocking_get branch October 12, 2018 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants