Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Fix switchMap incorrect sync-fusion & error management #6616

Merged
merged 1 commit into from Aug 14, 2019

Conversation

akarnokd
Copy link
Member

This PR fixes the incorrect request call inside switchMap when working with sync-fused sources.

Fixes: #6615

@akarnokd akarnokd added the 3.x label Aug 14, 2019
@akarnokd akarnokd added this to the 3.0 milestone Aug 14, 2019
@codecov
Copy link

codecov bot commented Aug 14, 2019

Codecov Report

Merging #6616 into 3.x will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6616      +/-   ##
============================================
- Coverage     98.17%   98.13%   -0.04%     
+ Complexity     6189     6188       -1     
============================================
  Files           678      678              
  Lines         44787    44792       +5     
  Branches       6172     6173       +1     
============================================
- Hits          43968    43958      -10     
- Misses          280      286       +6     
- Partials        539      548       +9
Impacted Files Coverage Δ Complexity Δ
...internal/operators/flowable/FlowableSwitchMap.java 95.79% <100%> (+0.08%) 3 <0> (ø) ⬇️
...rnal/operators/observable/ObservableSwitchMap.java 93.15% <100%> (-3.14%) 3 <0> (ø)
...activex/internal/observers/QueueDrainObserver.java 97.43% <0%> (-2.57%) 21% <0%> (-1%)
...ava/io/reactivex/processors/BehaviorProcessor.java 96.58% <0%> (-2.44%) 51% <0%> (ø)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 90.72% <0%> (-2.07%) 2% <0%> (ø)
...ternal/operators/observable/ObservablePublish.java 97.29% <0%> (-1.81%) 16% <0%> (-1%)
...rnal/operators/flowable/FlowableFlatMapSingle.java 92.52% <0%> (-1.73%) 2% <0%> (ø)
...nternal/operators/observable/ObservableCreate.java 96.58% <0%> (-1.71%) 2% <0%> (ø)
...java/io/reactivex/processors/UnicastProcessor.java 98.8% <0%> (-1.2%) 67% <0%> (-1%)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2572fa7...51b1f2b. Read the comment docs.

@akarnokd akarnokd merged commit a644739 into ReactiveX:3.x Aug 14, 2019
@akarnokd akarnokd deleted the SwitchMapFusionFix3x branch August 14, 2019 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flowable.fromIterable does not work as expected when used in switchMap
2 participants