Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Fix concurrent clear in observeOn while output-fused #6708

Merged
merged 1 commit into from
Nov 12, 2019

Conversation

akarnokd
Copy link
Member

There was another cancel-clear race leading to NPE or infinite loop inside both observeOn implementations.

Related: #6676

@codecov
Copy link

codecov bot commented Nov 11, 2019

Codecov Report

Merging #6708 into 3.x will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##               3.x    #6708      +/-   ##
===========================================
- Coverage     98.1%   98.08%   -0.03%     
+ Complexity    6188     6185       -3     
===========================================
  Files          677      677              
  Lines        44657    44657              
  Branches      6170     6170              
===========================================
- Hits         43810    43800      -10     
- Misses         309      313       +4     
- Partials       538      544       +6
Impacted Files Coverage Δ Complexity Δ
...internal/operators/flowable/FlowableObserveOn.java 96.65% <100%> (ø) 3 <0> (ø) ⬇️
...rnal/operators/observable/ObservableObserveOn.java 100% <100%> (ø) 3 <0> (ø) ⬇️
.../operators/flowable/FlowableBlockingSubscribe.java 93.02% <0%> (-4.66%) 10% <0%> (-1%)
...rnal/operators/flowable/FlowableFlatMapSingle.java 92.44% <0%> (-2.91%) 2% <0%> (ø)
...rnal/operators/observable/ObservableSwitchMap.java 91.57% <0%> (-2.11%) 3% <0%> (ø)
.../internal/disposables/ListCompositeDisposable.java 98% <0%> (-2%) 34% <0%> (-1%)
...nternal/operators/observable/ObservableWindow.java 98% <0%> (-2%) 3% <0%> (ø)
...ernal/operators/flowable/FlowableFromIterable.java 96.25% <0%> (-1.61%) 5% <0%> (ø)
.../operators/observable/ObservableFlatMapSingle.java 91.26% <0%> (-1.59%) 2% <0%> (ø)
...ivex/rxjava3/subscribers/SerializedSubscriber.java 98.86% <0%> (-1.14%) 26% <0%> (-1%)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e7abf2...5e6267f. Read the comment docs.

@akarnokd akarnokd merged commit df2cdb7 into ReactiveX:3.x Nov 12, 2019
@akarnokd akarnokd deleted the ObserveOnClearFusionFix branch November 12, 2019 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants