Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Make DisposableContainer public API #6745

Merged
merged 1 commit into from
Dec 3, 2019

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Dec 3, 2019

Make the internal interface DisposableContainer public as it can be one safely.

(I've seen some 3rd party usage in custom containers, this will make them now legit on 3.x.)

Edit
Also should resolve the OSGi private reference warning.

Resolves #6742

@codecov
Copy link

codecov bot commented Dec 3, 2019

Codecov Report

Merging #6745 into 3.x will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6745      +/-   ##
============================================
- Coverage     98.12%   98.08%   -0.05%     
+ Complexity     6189     6187       -2     
============================================
  Files           677      677              
  Lines         44663    44663              
  Branches       6171     6171              
============================================
- Hits          43825    43806      -19     
- Misses          299      311      +12     
- Partials        539      546       +7
Impacted Files Coverage Δ Complexity Δ
.../internal/disposables/ListCompositeDisposable.java 98% <ø> (-2%) 34 <0> (-1)
...rxjava3/internal/schedulers/ScheduledRunnable.java 100% <ø> (ø) 30 <0> (ø) ⬇️
...tivex/rxjava3/disposables/CompositeDisposable.java 100% <ø> (ø) 40 <0> (ø) ⬇️
...x/rxjava3/internal/schedulers/NewThreadWorker.java 94.91% <ø> (ø) 19 <0> (ø) ⬇️
.../operators/flowable/FlowableBlockingSubscribe.java 93.02% <0%> (-4.66%) 10% <0%> (-1%)
...l/operators/observable/ObservableFlatMapMaybe.java 88.73% <0%> (-3.53%) 2% <0%> (ø)
...ctivex/rxjava3/internal/util/QueueDrainHelper.java 97.22% <0%> (-2.78%) 56% <0%> (-2%)
...nternal/operators/observable/ObservableWindow.java 98% <0%> (-2%) 3% <0%> (ø)
...ternal/operators/completable/CompletableMerge.java 95.94% <0%> (-1.36%) 2% <0%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 445def8...319d1ef. Read the comment docs.

@akarnokd akarnokd merged commit e912237 into ReactiveX:3.x Dec 3, 2019
@akarnokd akarnokd deleted the DisposableContainerToStandard branch December 3, 2019 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OSGi warning about io.reactivex.rxjava3.disposables using private
2 participants