Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: [Java 8] Upgrade to Java 8, add Flowable.fromX operators #6765

Merged
merged 3 commits into from
Dec 17, 2019

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Dec 17, 2019

This PR upgrades RxJava to use and compile with Java 8.

  • Build target set to 8
  • AnimalSniffer set to 8
  • JavaDocs link to the official JDK set to 8
  • Implemented operators:
    • Flowable.fromOptional
    • Flowable.fromCompletionStage
    • Flowable.fromStream
  • Applied @SafeVarargs to many methods
  • Created marbles

Related #6695

image
image
image

@akarnokd akarnokd added this to the 3.0 milestone Dec 17, 2019
@akarnokd akarnokd added the Java 8 Issues and PRs related to Java 8 support label Dec 17, 2019
@codecov
Copy link

codecov bot commented Dec 17, 2019

Codecov Report

Merging #6765 into 3.x will increase coverage by 0.01%.
The diff coverage is 99.38%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6765      +/-   ##
============================================
+ Coverage     98.19%   98.21%   +0.01%     
- Complexity     6196     6205       +9     
============================================
  Files           679      681       +2     
  Lines         44622    44784     +162     
  Branches       6138     6164      +26     
============================================
+ Hits          43817    43983     +166     
+ Misses          283      281       -2     
+ Partials        522      520       -2
Impacted Files Coverage Δ Complexity Δ
.../reactivex/rxjava3/observers/BaseTestConsumer.java 97.23% <ø> (ø) 69 <0> (ø) ⬇️
.../main/java/io/reactivex/rxjava3/core/Flowable.java 100% <100%> (ø) 562 <3> (+3) ⬆️
...va3/internal/jdk8/FlowableFromCompletionStage.java 100% <100%> (ø) 2 <2> (?)
...ivex/rxjava3/internal/jdk8/FlowableFromStream.java 99.23% <99.23%> (ø) 5 <5> (?)
...l/operators/observable/ObservableFlatMapMaybe.java 85.91% <0%> (-9.16%) 2% <0%> (ø)
...perators/single/SingleFlatMapIterableFlowable.java 94.16% <0%> (-2.5%) 2% <0%> (ø)
...rnal/operators/flowable/FlowableFlatMapSingle.java 94.18% <0%> (-2.33%) 2% <0%> (ø)
.../internal/disposables/ListCompositeDisposable.java 98% <0%> (-2%) 34% <0%> (-1%)
...ternal/operators/completable/CompletableMerge.java 95.94% <0%> (-1.36%) 2% <0%> (ø)
...ava3/internal/operators/parallel/ParallelJoin.java 92.04% <0%> (-1.14%) 3% <0%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f96821f...3c19f8d. Read the comment docs.

@akarnokd akarnokd merged commit 735add2 into ReactiveX:3.x Dec 17, 2019
@akarnokd akarnokd deleted the Jdk8Ops_1217 branch December 17, 2019 16:28
@He-Pin
Copy link
Contributor

He-Pin commented Dec 17, 2019

With this move, there are many we can help.

@He-Pin
Copy link
Contributor

He-Pin commented Dec 17, 2019

Should remove the usage of Optional.of with Optional.ofNullable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Enhancement Java 8 Issues and PRs related to Java 8 support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants