Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: XProcessor.offer to throw NPE immediately #6799

Merged
merged 1 commit into from
Dec 26, 2019

Conversation

akarnokd
Copy link
Member

Make offer throw a NullPointerException immediately instead of turning it into an error signal. In addition, have MulticastProcessor.offer throw an IllegalStateException if called when the processor is in fusion mode.

Resolves #6794

@akarnokd akarnokd added this to the 3.0 milestone Dec 26, 2019
@codecov
Copy link

codecov bot commented Dec 26, 2019

Codecov Report

Merging #6799 into 3.x will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6799      +/-   ##
============================================
- Coverage     98.21%   98.17%   -0.05%     
  Complexity     6375     6375              
============================================
  Files           711      711              
  Lines         46217    46214       -3     
  Branches       6329     6330       +1     
============================================
- Hits          45393    45370      -23     
- Misses          298      309      +11     
- Partials        526      535       +9
Impacted Files Coverage Δ Complexity Δ
...eactivex/rxjava3/processors/BehaviorProcessor.java 98.02% <100%> (+1.44%) 49 <4> (-2) ⬇️
...reactivex/rxjava3/processors/PublishProcessor.java 100% <100%> (ø) 42 <4> (-1) ⬇️
...activex/rxjava3/processors/MulticastProcessor.java 98.68% <100%> (+1.32%) 84 <4> (+1) ⬆️
...nternal/operators/observable/ObservableCreate.java 79.48% <0%> (-19.66%) 2% <0%> (ø)
...observable/ObservableWindowSubscribeIntercept.java 87.5% <0%> (-12.5%) 4% <0%> (-1%)
.../operators/observable/ObservableFlatMapSingle.java 92.85% <0%> (-3.18%) 2% <0%> (ø)
...tivex/rxjava3/internal/jdk8/ParallelCollector.java 91.81% <0%> (-2.73%) 2% <0%> (ø)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 91.14% <0%> (-2.61%) 2% <0%> (ø)
...nternal/operators/observable/ObservableWindow.java 98.18% <0%> (-1.82%) 3% <0%> (ø)
...rnal/operators/flowable/FlowableFlatMapSingle.java 92.44% <0%> (-1.75%) 2% <0%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d00eb1...482bd2b. Read the comment docs.

@akarnokd akarnokd merged commit 38bcd5e into ReactiveX:3.x Dec 26, 2019
@akarnokd akarnokd deleted the XProcessorOfferToNPE branch December 26, 2019 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.x: XProcessor.offer to throw NPE instead of signaling it
1 participant