Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Add blockingForEach(Consumer, int) overload #6800

Merged
merged 1 commit into from
Dec 26, 2019

Conversation

akarnokd
Copy link
Member

The underlying blockingIterable already supported the custom prefetch overload and this PR exposes it as a new blockingForEach overload.

In addition, the Javadocs incorrectly stated blockingForEach operated in an unbounded-in fashion. It uses the usual stable-prefetch with 75% re-request amount.

Resolves #6784

@akarnokd akarnokd added this to the 3.0 milestone Dec 26, 2019
@codecov
Copy link

codecov bot commented Dec 26, 2019

Codecov Report

Merging #6800 into 3.x will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6800      +/-   ##
============================================
+ Coverage     98.21%   98.24%   +0.03%     
- Complexity     6375     6379       +4     
============================================
  Files           711      711              
  Lines         46217    46221       +4     
  Branches       6329     6329              
============================================
+ Hits          45393    45411      +18     
+ Misses          298      286      -12     
+ Partials        526      524       -2
Impacted Files Coverage Δ Complexity Δ
.../main/java/io/reactivex/rxjava3/core/Flowable.java 100% <100%> (ø) 578 <3> (+1) ⬆️
...ain/java/io/reactivex/rxjava3/core/Observable.java 100% <100%> (ø) 554 <3> (+1) ⬆️
...observable/ObservableWindowSubscribeIntercept.java 87.5% <0%> (-12.5%) 4% <0%> (-1%)
...nternal/operators/parallel/ParallelReduceFull.java 91.08% <0%> (-3.97%) 2% <0%> (ø)
.../operators/observable/ObservableFlatMapSingle.java 93.65% <0%> (-2.39%) 2% <0%> (ø)
...ternal/operators/observable/ObservablePublish.java 97.29% <0%> (-1.81%) 16% <0%> (-1%)
...rnal/operators/flowable/FlowableFlatMapSingle.java 92.44% <0%> (-1.75%) 2% <0%> (ø)
...a3/internal/operators/flowable/FlowableCreate.java 94.17% <0%> (-1.3%) 6% <0%> (ø)
...nternal/operators/observable/ObservableCreate.java 98.29% <0%> (-0.86%) 2% <0%> (ø)
...perators/single/SingleFlatMapIterableFlowable.java 95.83% <0%> (-0.84%) 2% <0%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d00eb1...14ef580. Read the comment docs.

@akarnokd akarnokd merged commit d1cbf57 into ReactiveX:3.x Dec 26, 2019
@akarnokd akarnokd deleted the BlockingForEachPrefetch branch December 26, 2019 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.x: Add Flowable.blockingForEach overload with configurable prefetch
1 participant