Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Add nullability annotations to type arguments #6840

Merged
merged 1 commit into from Jan 14, 2020

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Jan 13, 2020

Annotate type argument use with @NonNull.

Resolves #6766

@akarnokd akarnokd added this to the 3.0 milestone Jan 13, 2020
@codecov
Copy link

codecov bot commented Jan 13, 2020

Codecov Report

Merging #6840 into 3.x will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##               3.x    #6840      +/-   ##
===========================================
- Coverage     98.3%   98.28%   -0.03%     
+ Complexity    6380     6379       -1     
===========================================
  Files          715      715              
  Lines        46529    46529              
  Branches      6388     6388              
===========================================
- Hits         45741    45729      -12     
- Misses         280      284       +4     
- Partials       508      516       +8
Impacted Files Coverage Δ Complexity Δ
...o/reactivex/rxjava3/processors/AsyncProcessor.java 98.95% <ø> (ø) 45 <0> (ø) ⬇️
...va/io/reactivex/rxjava3/plugins/RxJavaPlugins.java 100% <ø> (ø) 146 <0> (ø) ⬇️
src/main/java/io/reactivex/rxjava3/core/Maybe.java 100% <ø> (ø) 179 <0> (ø) ⬇️
...in/java/io/reactivex/rxjava3/core/Completable.java 100% <ø> (ø) 120 <0> (ø) ⬇️
...reactivex/rxjava3/processors/PublishProcessor.java 100% <100%> (ø) 42 <0> (ø) ⬇️
...eactivex/rxjava3/processors/BehaviorProcessor.java 99.01% <100%> (+2.46%) 50 <0> (ø) ⬇️
.../reactivex/rxjava3/processors/ReplayProcessor.java 97.79% <100%> (ø) 52 <0> (ø) ⬇️
...reactivex/rxjava3/processors/UnicastProcessor.java 100% <100%> (ø) 66 <0> (ø) ⬇️
.../main/java/io/reactivex/rxjava3/core/Flowable.java 100% <100%> (ø) 576 <2> (ø) ⬇️
...activex/rxjava3/processors/MulticastProcessor.java 98.68% <100%> (+0.43%) 84 <0> (+1) ⬆️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04800ae...7b9fa31. Read the comment docs.

@akarnokd akarnokd merged commit fb6dab6 into ReactiveX:3.x Jan 14, 2020
@akarnokd akarnokd deleted the NullBaseAnnotations3x branch January 14, 2020 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.x: Add missing NonNull annotations to the standard methods
1 participant