Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Improve wording of operators #6843

Merged
merged 1 commit into from
Jan 14, 2020

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Jan 14, 2020

  • Reword sentences with "modifies" and "instructs".
  • Reword "the source X" to "the current X".
  • Reword a couple of other operator sentences.

Related #6819
Resolves #6821

@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #6843 into 3.x will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6843      +/-   ##
============================================
+ Coverage     98.25%   98.28%   +0.02%     
- Complexity     6380     6381       +1     
============================================
  Files           715      715              
  Lines         46529    46529              
  Branches       6388     6388              
============================================
+ Hits          45717    45730      +13     
+ Misses          293      286       -7     
+ Partials        519      513       -6
Impacted Files Coverage Δ Complexity Δ
.../main/java/io/reactivex/rxjava3/core/Flowable.java 100% <ø> (ø) 576 <0> (ø) ⬇️
src/main/java/io/reactivex/rxjava3/core/Maybe.java 100% <ø> (ø) 179 <0> (ø) ⬇️
...in/java/io/reactivex/rxjava3/core/Completable.java 100% <ø> (ø) 120 <0> (ø) ⬇️
...rc/main/java/io/reactivex/rxjava3/core/Single.java 100% <ø> (ø) 151 <0> (ø) ⬇️
...ain/java/io/reactivex/rxjava3/core/Observable.java 100% <ø> (ø) 551 <0> (ø) ⬇️
...java3/internal/observers/FutureSingleObserver.java 94.33% <0%> (-3.78%) 24% <0%> (-1%)
.../operators/observable/ObservableFlatMapSingle.java 89.68% <0%> (-1.59%) 2% <0%> (ø)
...3/internal/operators/flowable/FlowableGroupBy.java 95.59% <0%> (-1.26%) 3% <0%> (ø)
...ivex/rxjava3/subscribers/SerializedSubscriber.java 98.86% <0%> (-1.14%) 26% <0%> (-1%)
...ava3/internal/operators/maybe/MaybeMergeArray.java 96.04% <0%> (-1.13%) 6% <0%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb6dab6...e7f8c6f. Read the comment docs.

@akarnokd akarnokd merged commit 9ed5416 into ReactiveX:3.x Jan 14, 2020
@akarnokd akarnokd deleted the ModifiesInstructsDocFix3x branch January 14, 2020 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.x: Reword javadocs saying the operator "modifies" the current source
1 participant