Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Add Single/Completable retryUntil + marbles #6869

Merged
merged 1 commit into from
Jan 25, 2020

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Jan 25, 2020

retryUntil was missing from Single and Completable.

Added marble for Maybe as well.

Related #6852, #5806

image
image
image

@codecov
Copy link

codecov bot commented Jan 25, 2020

Codecov Report

Merging #6869 into 3.x will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6869      +/-   ##
============================================
+ Coverage     98.25%   98.29%   +0.04%     
- Complexity     6430     6433       +3     
============================================
  Files           719      719              
  Lines         46746    46750       +4     
  Branches       6401     6401              
============================================
+ Hits          45929    45953      +24     
+ Misses          293      283      -10     
+ Partials        524      514      -10
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/rxjava3/core/Maybe.java 100% <ø> (ø) 185 <0> (ø) ⬇️
...in/java/io/reactivex/rxjava3/core/Completable.java 100% <100%> (ø) 126 <1> (+1) ⬆️
...rc/main/java/io/reactivex/rxjava3/core/Single.java 100% <100%> (ø) 158 <1> (+1) ⬆️
...eactivex/rxjava3/processors/BehaviorProcessor.java 96.55% <0%> (-2.47%) 50% <0%> (ø)
...rnal/operators/observable/ObservableSwitchMap.java 91.57% <0%> (-2.11%) 3% <0%> (ø)
...ternal/operators/observable/ObservablePublish.java 97.29% <0%> (-1.81%) 16% <0%> (-1%)
...ternal/operators/flowable/FlowableSubscribeOn.java 96.61% <0%> (-1.7%) 2% <0%> (ø)
...internal/operators/flowable/FlowableSwitchMap.java 94.39% <0%> (-1.41%) 3% <0%> (ø)
...ernal/operators/flowable/FlowableFromIterable.java 95.18% <0%> (-1.07%) 5% <0%> (ø)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 95.31% <0%> (-1.05%) 2% <0%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 320a675...fab5b58. Read the comment docs.

@akarnokd akarnokd merged commit 0ed3572 into ReactiveX:3.x Jan 25, 2020
@akarnokd akarnokd deleted the RetryUntil3x branch January 25, 2020 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant