Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Add many fromX operators + marbles #6873

Merged
merged 1 commit into from
Jan 25, 2020
Merged

Conversation

akarnokd
Copy link
Member

Add a cross section of from operators (present fromAction .. fromSingle) :

Operator F O M S C
fromAction present present present absent (23) present
fromCompletable present present present absent (72) absent (73)
fromMaybe present present absent (73) present present
fromObservable present absent (73) present present present
fromPublisher present present present present present
fromRunnable present present present absent (23) present
fromSingle present present present absent (73) present

Related #6852

image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image

@akarnokd akarnokd added this to the 3.0 milestone Jan 25, 2020
@codecov
Copy link

codecov bot commented Jan 25, 2020

Codecov Report

Merging #6873 into 3.x will decrease coverage by 0.01%.
The diff coverage is 96.58%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6873      +/-   ##
============================================
- Coverage     98.27%   98.26%   -0.02%     
- Complexity     6446     6503      +57     
============================================
  Files           722      731       +9     
  Lines         46783    46968     +185     
  Branches       6401     6420      +19     
============================================
+ Hits          45977    46153     +176     
- Misses          289      298       +9     
  Partials        517      517
Impacted Files Coverage Δ Complexity Δ
...xjava3/internal/operators/maybe/MaybeToSingle.java 100% <ø> (ø) 3 <0> (ø) ⬇️
...in/java/io/reactivex/rxjava3/core/Completable.java 100% <ø> (ø) 128 <0> (ø) ⬇️
...internal/operators/maybe/MaybeFromCompletable.java 100% <ø> (ø) 3 <0> (ø) ⬇️
src/main/java/io/reactivex/rxjava3/core/Maybe.java 100% <100%> (ø) 190 <2> (+3) ⬆️
...operators/completable/CompletableToObservable.java 100% <100%> (ø) 2 <1> (ø) ⬇️
...l/operators/completable/CompletableFromAction.java 100% <100%> (ø) 5 <0> (+1) ⬆️
.../main/java/io/reactivex/rxjava3/core/Flowable.java 100% <100%> (ø) 588 <10> (+10) ⬆️
...nternal/operators/flowable/FlowableFromAction.java 100% <100%> (ø) 6 <6> (?)
...nal/operators/flowable/FlowableFromObservable.java 100% <100%> (ø) 2 <1> (ø) ⬇️
...ain/java/io/reactivex/rxjava3/core/Observable.java 100% <100%> (ø) 558 <5> (+5) ⬆️
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53ba435...55548f2. Read the comment docs.

@akarnokd akarnokd merged commit 26dacd7 into ReactiveX:3.x Jan 25, 2020
@akarnokd akarnokd deleted the FromX3x branch January 25, 2020 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant