Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Add Maybe/Completable toFuture #6875

Merged
merged 2 commits into from
Jan 26, 2020
Merged

Conversation

akarnokd
Copy link
Member

Add toFuture to Maybe and Completable.

Related #6852

image
image

@akarnokd akarnokd added this to the 3.0 milestone Jan 26, 2020
@codecov
Copy link

codecov bot commented Jan 26, 2020

Codecov Report

Merging #6875 into 3.x will increase coverage by 0.02%.
The diff coverage is 77.77%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6875      +/-   ##
============================================
+ Coverage     98.24%   98.27%   +0.02%     
- Complexity     6523     6527       +4     
============================================
  Files           733      733              
  Lines         47044    47052       +8     
  Branches       6424     6425       +1     
============================================
+ Hits          46217    46238      +21     
+ Misses          303      294       -9     
+ Partials        524      520       -4
Impacted Files Coverage Δ Complexity Δ
.../main/java/io/reactivex/rxjava3/core/Flowable.java 100% <ø> (ø) 588 <0> (ø) ⬇️
...ain/java/io/reactivex/rxjava3/core/Observable.java 100% <ø> (ø) 558 <0> (ø) ⬇️
src/main/java/io/reactivex/rxjava3/core/Maybe.java 100% <100%> (ø) 199 <1> (+1) ⬆️
...in/java/io/reactivex/rxjava3/core/Completable.java 100% <100%> (ø) 129 <1> (+1) ⬆️
...rc/main/java/io/reactivex/rxjava3/core/Single.java 100% <100%> (ø) 170 <1> (ø) ⬇️
...xjava3/internal/observers/FutureMultiObserver.java 94.91% <66.66%> (ø) 26 <1> (?)
.../operators/observable/ObservableFlatMapSingle.java 88.09% <0%> (-5.56%) 2% <0%> (ø)
.../operators/flowable/FlowableBlockingSubscribe.java 93.02% <0%> (-4.66%) 10% <0%> (-1%)
...java3/internal/schedulers/TrampolineScheduler.java 96.1% <0%> (-2.6%) 6% <0%> (ø)
...perators/single/SingleFlatMapIterableFlowable.java 95% <0%> (-1.67%) 2% <0%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5449b2...3984932. Read the comment docs.

@akarnokd akarnokd merged commit 8c85f5a into ReactiveX:3.x Jan 26, 2020
@akarnokd akarnokd deleted the ToFuture3x branch January 26, 2020 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant