Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Add various concatXDelayError operators #6881

Merged
merged 1 commit into from
Jan 27, 2020

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Jan 26, 2020

Add the following concat kind of operators:

  • Maybe.concatArrayEagerDelayError
  • Maybe.concatDelayError(Publisher, int)
  • Single.concatArrayDelayError
  • Single.concatArrayEagerDelayError
  • Single.concatDelayError + 2
  • Completable.concatArrayDelayError
  • Completable.concatDelayError + 2

Related #6852

image
image
image
image
image
image
image
image
image
image
image

In addition, the Maybe.concatDelayError(Publisher) marble has been fixed:

image

@codecov
Copy link

codecov bot commented Jan 26, 2020

Codecov Report

Merging #6881 into 3.x will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6881      +/-   ##
============================================
- Coverage     98.29%   98.25%   -0.04%     
- Complexity     6540     6547       +7     
============================================
  Files           735      735              
  Lines         47153    47163      +10     
  Branches       6432     6432              
============================================
- Hits          46349    46342       -7     
- Misses          289      297       +8     
- Partials        515      524       +9
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/rxjava3/core/Maybe.java 100% <100%> (ø) 204 <4> (+2) ⬆️
...rc/main/java/io/reactivex/rxjava3/core/Single.java 100% <100%> (ø) 180 <6> (+5) ⬆️
...in/java/io/reactivex/rxjava3/core/Completable.java 100% <100%> (ø) 134 <4> (+4) ⬆️
...tivex/rxjava3/internal/jdk8/ParallelCollector.java 89.9% <0%> (-8.26%) 2% <0%> (ø)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 90.1% <0%> (-5.21%) 2% <0%> (ø)
.../operators/observable/ObservableFlatMapSingle.java 88.88% <0%> (-4.77%) 2% <0%> (ø)
.../operators/flowable/FlowableBlockingSubscribe.java 93.02% <0%> (-4.66%) 10% <0%> (-1%)
...nternal/operators/parallel/ParallelReduceFull.java 91.08% <0%> (-1.99%) 2% <0%> (ø)
...ava3/internal/operators/parallel/ParallelJoin.java 92.04% <0%> (-1.14%) 3% <0%> (ø)
...ivex/rxjava3/subscribers/SerializedSubscriber.java 98.86% <0%> (-1.14%) 26% <0%> (-1%)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57bd1a9...d2677ad. Read the comment docs.

@akarnokd akarnokd merged commit 9283700 into ReactiveX:3.x Jan 27, 2020
@akarnokd akarnokd deleted the ConcatX3x branch January 27, 2020 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant