Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Add Completable.onErrorReturn[Item] #6886

Merged
merged 1 commit into from
Jan 28, 2020

Conversation

akarnokd
Copy link
Member

The operators were already available elsewhere.

Related #6852

image
image

In addition, the Maybe variants have received updated marbles as well:

image
image

Related #5806

@akarnokd akarnokd added this to the 3.0 milestone Jan 28, 2020
@codecov
Copy link

codecov bot commented Jan 28, 2020

Codecov Report

Merging #6886 into 3.x will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6886      +/-   ##
============================================
- Coverage     98.26%   98.23%   -0.03%     
- Complexity     6569     6573       +4     
============================================
  Files           735      736       +1     
  Lines         47204    47235      +31     
  Branches       6432     6433       +1     
============================================
+ Hits          46384    46402      +18     
- Misses          298      310      +12     
- Partials        522      523       +1
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/rxjava3/core/Maybe.java 100% <ø> (ø) 209 <0> (ø) ⬇️
...3/internal/operators/maybe/MaybeOnErrorReturn.java 100% <100%> (ø) 2 <1> (ø) ⬇️
...in/java/io/reactivex/rxjava3/core/Completable.java 100% <100%> (ø) 139 <2> (+2) ⬆️
...perators/completable/CompletableOnErrorReturn.java 100% <100%> (ø) 2 <2> (?)
...a3/internal/operators/flowable/FlowableCreate.java 90.29% <0%> (-6.15%) 6% <0%> (ø)
...rnal/operators/flowable/FlowableFlatMapSingle.java 92.44% <0%> (-2.91%) 2% <0%> (ø)
...l/operators/observable/ObservableFlatMapMaybe.java 92.95% <0%> (-2.12%) 2% <0%> (ø)
...rnal/operators/observable/ObservableSwitchMap.java 91.57% <0%> (-2.11%) 3% <0%> (ø)
...nternal/operators/observable/ObservableWindow.java 98.18% <0%> (-1.82%) 3% <0%> (ø)
...ctivex/rxjava3/internal/util/QueueDrainHelper.java 98.61% <0%> (-1.39%) 57% <0%> (-1%)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f86753a...8a940f3. Read the comment docs.

@akarnokd akarnokd merged commit e077ed8 into ReactiveX:3.x Jan 28, 2020
@akarnokd akarnokd deleted the CompletableOnErrorReturnItem branch January 28, 2020 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant