3.x: Fix groupBy not requesting more if a group is cancelled w/ items #6895
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a group is cancelled with unconsumed item in its buffer, the operator stopped requesting more thus hanging other groups. In 3.x the operator was somewhat strenghtened for this case except one case when the cancellation happens outside the drain loop.
The fix is to invoke
drain()
from cancel for it to have the cleanup and replenishment happen.Fixes #6889