Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Allow setting the drift tolerance timeunit via system property #6969

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

akarnokd
Copy link
Member

Adds the new system property rx3.scheduler.drift-tolerance-unit to allow specifying a more fine-grained tolerance amount.

Resolves #6968

@akarnokd akarnokd added this to the 3.1 milestone Apr 27, 2020
@codecov
Copy link

codecov bot commented Apr 27, 2020

Codecov Report

Merging #6969 into 3.x will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6969      +/-   ##
============================================
+ Coverage     99.60%   99.63%   +0.02%     
- Complexity     6666     6670       +4     
============================================
  Files           742      742              
  Lines         47248    47254       +6     
  Branches       6369     6370       +1     
============================================
+ Hits          47061    47080      +19     
+ Misses           60       55       -5     
+ Partials        127      119       -8     
Impacted Files Coverage Δ Complexity Δ
...main/java/io/reactivex/rxjava3/core/Scheduler.java 100.00% <100.00%> (ø) 14.00 <4.00> (+3.00)
...nternal/operators/parallel/ParallelReduceFull.java 91.08% <0.00%> (-3.97%) 2.00% <0.00%> (ø%)
.../internal/disposables/ListCompositeDisposable.java 98.00% <0.00%> (-2.00%) 34.00% <0.00%> (-1.00%)
...tivex/rxjava3/disposables/CompositeDisposable.java 98.14% <0.00%> (-1.86%) 39.00% <0.00%> (-1.00%)
...ternal/operators/flowable/FlowableSubscribeOn.java 98.30% <0.00%> (-1.70%) 2.00% <0.00%> (ø%)
...java3/internal/operators/flowable/FlowableZip.java 98.97% <0.00%> (-1.03%) 6.00% <0.00%> (ø%)
...3/internal/operators/flowable/FlowableGroupBy.java 99.05% <0.00%> (-0.63%) 3.00% <0.00%> (ø%)
...a/io/reactivex/rxjava3/subjects/ReplaySubject.java 98.75% <0.00%> (-0.42%) 49.00% <0.00%> (ø%)
...a3/internal/operators/flowable/FlowableCreate.java 98.70% <0.00%> (-0.33%) 6.00% <0.00%> (ø%)
...l/operators/observable/ObservableFlatMapMaybe.java 91.54% <0.00%> (ø) 2.00% <0.00%> (ø%)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbee37a...0ac4e84. Read the comment docs.

@akarnokd akarnokd merged commit 77c2ef1 into ReactiveX:3.x Apr 27, 2020
@akarnokd akarnokd deleted the ClockdriftUOM branch April 27, 2020 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: allow to set CLOCK_DRIFT_TOLERANCE_NANOS in seconds/milliseconds
2 participants