Removed unnecessary upstream.cancel() call for casually finished upstream sequences. #6992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sobersanta
commented
May 20, 2020
•
sobersanta
commented
- no upstream.cancel() in FlowablePublishMulticast when the sequence is finished normally via onComplete/onError from upstream;
- minor code cleanup - unnecessary Disposable implementation to avoid method name clash
- Fixes 3.x: unnecessary call to upstream .cancel() in FlowablePublishMulticast operator #6989
- FlowablePublishFunctionTest.java refactored to use lambdas
… finished normally via onComplete/onError from upstream; minor code cleanup - unnecessary Disposable implementation to avoid method name clash
akarnokd
reviewed
May 20, 2020
| public void noUpstreamCancelOnCasualChainClose() { | ||
| AtomicBoolean parentUpstreamCancelled = new AtomicBoolean(false); | ||
| Flowable.range(1, 10) | ||
| .doOnCancel(new Action() { |
There was a problem hiding this comment.
You can use lambdas in tests now.
There was a problem hiding this comment.
Cool!
Should I change it?
There was a problem hiding this comment.
If that's fine, I've refactored whole file to lambdas.
Codecov Report
@@ Coverage Diff @@
## 3.x #6992 +/- ##
============================================
+ Coverage 99.49% 99.52% +0.03%
- Complexity 6669 6670 +1
============================================
Files 742 742
Lines 47267 47268 +1
Branches 6374 6375 +1
============================================
+ Hits 47026 47044 +18
+ Misses 114 105 -9
+ Partials 127 119 -8 Continue to review full report at Codecov.
|
added 2 commits
May 20, 2020 20:50
akarnokd
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.