3.x: Flowable scan/scanWith backpressure documentation update #7110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documented Flowable initial value scan variants upstream consumption pattern as it is different from the variant with no initial value.
akarnokd
reviewed
Nov 12, 2020
| @@ -14736,6 +14736,8 @@ public final void safeSubscribe(@NonNull Subscriber<@NonNull ? super T> subscrib | |||
| * <dt><b>Backpressure:</b></dt> | |||
| * <dd>The operator honors downstream backpressure and expects the current {@code Flowable} to honor backpressure as well. | |||
| * Violating this expectation, a {@link MissingBackpressureException} <em>may</em> get signaled somewhere downstream.</dd> | |||
| * <dd>The downstream request pattern is not preserved across this operator. | |||
There was a problem hiding this comment.
You don't have to start a new <dd> here, just add the text on a new line inside the previous <dd>.
There was a problem hiding this comment.
- merge
<dd>sections
akarnokd
approved these changes
Nov 12, 2020
Codecov Report
@@ Coverage Diff @@
## 3.x #7110 +/- ##
============================================
+ Coverage 99.51% 99.53% +0.01%
Complexity 6670 6670
============================================
Files 742 742
Lines 47275 47275
Branches 6374 6374
============================================
+ Hits 47048 47054 +6
Misses 104 104
+ Partials 123 117 -6 Continue to review full report at Codecov.
|
|
Thanks! |
|
My pleasure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documented Flowable initial value scan variants upstream consumption pattern as it is different from the variant with no initial value.
Resolves #7109