Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement the ElementAt operator and add it to rxjava-scala #966

Merged
merged 3 commits into from
Mar 25, 2014

Conversation

zsxwing
Copy link
Member

@zsxwing zsxwing commented Mar 15, 2014

No description provided.

@cloudbees-pull-request-builder

RxJava-pull-requests #906 FAILURE
Looks like there's a problem with this pull request


@Override
public void call(final Subscriber<? super T> subscriber) {
source.subscribe(new Subscriber<T>(subscriber) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could have implemented it via Operator and lift. That way, you don't need to wrap the source.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Thank you.

@cloudbees-pull-request-builder

RxJava-pull-requests #907 FAILURE
Looks like there's a problem with this pull request

@zsxwing
Copy link
Member Author

zsxwing commented Mar 21, 2014

Rebased

@cloudbees-pull-request-builder

RxJava-pull-requests #916 SUCCESS
This pull request looks good

benjchristensen added a commit that referenced this pull request Mar 25, 2014
Reimplement the ElementAt operator and add it to rxjava-scala
@benjchristensen benjchristensen merged commit d6732ad into ReactiveX:master Mar 25, 2014
@zsxwing zsxwing deleted the elementAt branch March 28, 2014 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants