Revise lesson 36 and some API calls for RxJS 5 #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The button to show all answers was not displaying code snippets for lessons that did not require answers from users (e.g. 34). Also, a guard was added to prevent JS errors from appearing if a lesson does not have code to save (e.g. 42 at this time of writing).
Rewrites both the discussion and code sample for lesson 36 in light of the API changes in RxJS 5. Note that `forEach` is no longer synonymous with `subscribe`. Addresses #157.
|
This needs merged asap. I'm learning rx now and couldn't see what was meant to be happening. The concurrent exercises using |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
I've made some changes to address #157.
My most significant change is rewriting the lesson 36 discussion such that the concepts pertain to the RxJS 5 API. The new RxJS documentation was very helpful in assisting me with this.
Also took the liberty of folding in a fix for a usability problem with the show all answers button at the top of the page, whereby it wasn't showing code for some lessons.