fix(windowTime): does not emit on unsubscribed window

ReactiveX · Feb 8, 2016 · e7cbe88 · e7cbe88
1 parent 989a14e
commit e7cbe88
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/spec/operators/windowTime-spec.js b/spec/operators/windowTime-spec.js
@@ -183,12 +183,9 @@ describe('Observable.prototype.windowTime', function () {
     expectObservable(result, unsub).toBe(expected, values);
     expectSubscriptions(source.subscriptions).toBe(sourceSubs);
     rxTestScheduler.schedule(function () {
-      try {
+      expect(function () {
         window.subscribe();
-      }
-      catch (err) {
-        expect(err.message).toBe('Cannot subscribe to a disposed Subject.');
-      }
+      }).toThrow(new Rx.ObjectUnsubscribedError());
     }, 150);
   });
 

diff --git a/src/operator/windowTime.ts b/src/operator/windowTime.ts
@@ -51,7 +51,10 @@ class WindowTimeSubscriber<T> extends Subscriber<T> {
     const windows = this.windows;
     const len = windows.length;
     for (let i = 0; i < len; i++) {
-      windows[i].next(value);
+      const window = windows[i];
+      if (!window.isUnsubscribed) {
+        window.next(value);
+      }
     }
   }
 
@@ -66,7 +69,10 @@ class WindowTimeSubscriber<T> extends Subscriber<T> {
   protected _complete() {
     const windows = this.windows;
     while (windows.length > 0) {
-      windows.shift().complete();
+      const window = windows.shift();
+      if (!window.isUnsubscribed) {
+        window.complete();
+      }
     }
     this.destination.complete();
   }