Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Subject): Document changes to Subject.create #1241

Closed

Conversation

rgbkrk
Copy link
Contributor

@rgbkrk rgbkrk commented Jan 23, 2016

Guide those migrating from RxJS 4 who are using Subject.create to
let them know about the new argument ordering.

@benlesh
Copy link
Member

benlesh commented Jan 25, 2016

Actually, it looks like we have the arguments reversed. It should be Subject.create(subscriber, observable), because Subscriber is an Observer. :\

@trxcllnt, I think you implemented this one, is there a reason for the reversal of argument order here?

@trxcllnt
Copy link
Member

@Blesh no, just typed it that way a while back and it stuck.

Guide those migrating from RxJS 4 who are using `Subject.create` to
let them know about the new argument ordering.
@kwonoj
Copy link
Member

kwonoj commented Feb 2, 2016

Seems it's clarified and we can introduce changes to interface actually, so I have filed #1285 to track those and closing this PR. @rgbkrk , huge appreciate to catch this and take effort to bring PR for those - let's track root reason via filed issue. Thanks again!

@kwonoj kwonoj closed this Feb 2, 2016
@rgbkrk rgbkrk deleted the migration-guide-subject-create branch February 2, 2016 14:42
@rgbkrk
Copy link
Contributor Author

rgbkrk commented Feb 11, 2016

Thanks for tackling this.

@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants