refactor(Subscription): return always subscription when calling Subscription.add() #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry for nitpicking - doesn't |
tetsuharuohzeki
force-pushed
the
always-return-subscription
branch
from
4dab77c
to
6fb7c42
Compare
|
@kwonoj I fixed the message. |
tetsuharuohzeki
changed the title
tetsuharuohzeki
force-pushed
the
always-return-subscription
branch
from
6fb7c42
to
5f280ed
Compare
|
rebased! |
| it('Should returns the passed one if passed a AnonymousSubscription having not function `unsubscribe` member', () => { | ||
| const sub = new Subscription(); | ||
| const arg = { | ||
| isUnsubscribed: true, |
There was a problem hiding this comment.
oops. this should be false for testing correctly
tetsuharuohzeki
force-pushed
the
always-return-subscription
branch
from
5f280ed
to
94ce8ac
Compare
tetsuharuohzeki
force-pushed
the
always-return-subscription
branch
from
94ce8ac
to
54b40b6
Compare
|
@kwonoj I rebased this on the latest master. |
|
LGTM, one more rebase and I'll merge! |
…ription.add() BREAKING CHANGE: This fixes ReactiveX#1656. This makes Subscription.add() returns always subscription. if you checks the returned value of it. you might need to change it.
tetsuharuohzeki
force-pushed
the
always-return-subscription
branch
from
54b40b6
to
03f9d0c
Compare
|
Thank you! 💃 |
|
you're welcome! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
This fixes #1656.
This makes Subscription.add() returns always subscription.
if you checks the returned value of it. you might need to change it.