Refactor #2457 for v6 #3963
Merged
Refactor #2457 for v6 #3963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlesh
approved these changes
Jul 27, 2018
|
@benlesh I've used |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR refactors #2457 for v6 and changes a few identifiers so that they are prefixed with underscores.
/cc @jayphelps
I did try to use git-blame-someone-else to credit the PR's author, but the command left the branch in an indeterminate state, so I just aborted the rebase. If someone else wants to have a crack at updating the PR - to credit the author - the author's details are:Mateusz Podlasin <Podlas29@gmail.com>UPDATE: I've edited the commits manually to credit the author.
Related issue (if exists): #2457 #2459