Upgrade RxJS to TS-3.7 #5124
Merged
Upgrade RxJS to TS-3.7 #5124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolodny
force-pushed
the
works-with-ts-36
branch
from
fbd64cb
to
e6cfedb
Compare
cartant
approved these changes
Nov 7, 2019
kolodny
changed the title
3 tasks
|
@kolodny looks like there's one build error that needs to be resolved before I can merge this. |
Resolved. |
benlesh
approved these changes
Nov 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should unblock Google from compiling RxJS with TS3.6, the other issues "should" be able to be fixed internally.
This should make a dent on #5047