refactor: use n-args for endWith scheduler signatures #6085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartant
force-pushed
the
cartant/end-with
branch
from
593d473
to
80ce72b
Compare
cartant
force-pushed
the
cartant/end-with
branch
from
80ce72b
to
f3849b9
Compare
benlesh
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR refactors the
Scheduler-relatedendWithsignatures to use the n-args approach.I realize that these sigs are deprecated, but we already have deprecated sigs in other operators that use n-args, so, IMO, things are less confusing if n-args is used wherever possible. See also the reasons listed in #6092 (comment)
Related issue (if exists): Nope