Fixed: Allow decimals for Custom Format size

(cherry picked from commit 7f5ddff568ce9f87bd45420cbd36690b190bd633) Closes #2839
Readarr · Aug 19, 2023 · 2081f2e · 2081f2e
1 parent c10a325
commit 2081f2e
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 1 deletion.
diff --git a/frontend/src/Components/Form/NumberInput.js b/frontend/src/Components/Form/NumberInput.js
@@ -41,7 +41,7 @@ class NumberInput extends Component {
   componentDidUpdate(prevProps, prevState) {
     const { value } = this.props;
 
-    if (value !== prevProps.value && !this.state.isFocused) {
+    if (!isNaN(value) && value !== prevProps.value && !this.state.isFocused) {
       this.setState({
         value: value == null ? '' : value.toString()
       });

diff --git a/frontend/src/Helpers/Props/inputTypes.js b/frontend/src/Helpers/Props/inputTypes.js
@@ -6,6 +6,7 @@ export const BOOKSHELF = 'bookshelf';
 export const KEY_VALUE_LIST = 'keyValueList';
 export const MONITOR_BOOKS_SELECT = 'monitorBooksSelect';
 export const MONITOR_NEW_ITEMS_SELECT = 'monitorNewItemsSelect';
+export const FLOAT = 'float';
 export const NUMBER = 'number';
 export const OAUTH = 'oauth';
 export const PASSWORD = 'password';
@@ -34,6 +35,7 @@ export const all = [
   KEY_VALUE_LIST,
   MONITOR_BOOKS_SELECT,
   MONITOR_NEW_ITEMS_SELECT,
+  FLOAT,
   NUMBER,
   OAUTH,
   PASSWORD,

diff --git a/src/Readarr.Http/ClientSchema/Field.cs b/src/Readarr.Http/ClientSchema/Field.cs
@@ -19,6 +19,7 @@ public class Field
         public string Section { get; set; }
         public string Hidden { get; set; }
         public string Placeholder { get; set; }
+        public bool IsFloat { get; set; }
 
         public Field Clone()
         {

diff --git a/src/Readarr.Http/ClientSchema/SchemaBuilder.cs b/src/Readarr.Http/ClientSchema/SchemaBuilder.cs
@@ -124,6 +124,11 @@ private static FieldMapping[] GetFieldMapping(Type type, string prefix, Func<obj
                         field.Hidden = fieldAttribute.Hidden.ToString().FirstCharToLower();
                     }
 
+                    if (fieldAttribute.Type is FieldType.Number && propertyInfo.PropertyType == typeof(double))
+                    {
+                        field.IsFloat = true;
+                    }
+
                     var valueConverter = GetValueConverter(propertyInfo.PropertyType);
 
                     result.Add(new FieldMapping