New: Improve empty list messaging

(cherry picked from commit ee843259bca2d9764a3919b123524a51a3a16cce) Closes #2621
Readarr · Jun 27, 2023 · 55959e1 · 55959e1
1 parent 07451cb
commit 55959e1
Show file tree

Hide file tree

Showing 7 changed files with 30 additions and 21 deletions.
diff --git a/frontend/src/Settings/Tags/Tags.js b/frontend/src/Settings/Tags/Tags.js
@@ -1,8 +1,10 @@
 import PropTypes from 'prop-types';
 import React from 'react';
+import Alert from 'Components/Alert';
 import FieldSet from 'Components/FieldSet';
 import Link from 'Components/Link/Link';
 import PageSectionContent from 'Components/Page/PageSectionContent';
+import { kinds } from 'Helpers/Props';
 import translate from 'Utilities/String/translate';
 import TagConnector from './TagConnector';
 import styles from './Tags.css';
@@ -16,9 +18,9 @@ function Tags(props) {
   if (!items.length) {
     const wikiLink = <Link to='https://wiki.servarr.com/readarr/settings#tags'>here</Link>;
     return (
-      <div>
+      <Alert kind={kinds.INFO}>
         {translate('NoTagsHaveBeenAddedYet', [wikiLink])}
-      </div>
+      </Alert>
     );
   }
 

diff --git a/frontend/src/System/Events/LogsTable.js b/frontend/src/System/Events/LogsTable.js
@@ -1,5 +1,6 @@
 import PropTypes from 'prop-types';
 import React from 'react';
+import Alert from 'Components/Alert';
 import LoadingIndicator from 'Components/Loading/LoadingIndicator';
 import FilterMenu from 'Components/Menu/FilterMenu';
 import PageContent from 'Components/Page/PageContent';
@@ -11,7 +12,7 @@ import Table from 'Components/Table/Table';
 import TableBody from 'Components/Table/TableBody';
 import TableOptionsModalWrapper from 'Components/Table/TableOptions/TableOptionsModalWrapper';
 import TablePager from 'Components/Table/TablePager';
-import { align, icons } from 'Helpers/Props';
+import { align, icons, kinds } from 'Helpers/Props';
 import translate from 'Utilities/String/translate';
 import LogsTableRow from './LogsTableRow';
 
@@ -82,9 +83,9 @@ function LogsTable(props) {
 
         {
           isPopulated && !error && !items.length &&
-            <div>
-              No events found
-            </div>
+            <Alert kind={kinds.INFO}>
+              {translate('NoEventsFound')}
+            </Alert>
         }
 
         {

diff --git a/frontend/src/System/Logs/Files/LogFiles.js b/frontend/src/System/Logs/Files/LogFiles.js
@@ -11,7 +11,7 @@ import PageToolbarSection from 'Components/Page/Toolbar/PageToolbarSection';
 import PageToolbarSeparator from 'Components/Page/Toolbar/PageToolbarSeparator';
 import Table from 'Components/Table/Table';
 import TableBody from 'Components/Table/TableBody';
-import { icons } from 'Helpers/Props';
+import { icons, kinds } from 'Helpers/Props';
 import translate from 'Utilities/String/translate';
 import LogsNavMenu from '../LogsNavMenu';
 import LogFilesTableRow from './LogFilesTableRow';
@@ -118,9 +118,9 @@ class LogFiles extends Component {
 
           {
             !isFetching && !items.length &&
-              <div>
+              <Alert kind={kinds.INFO}>
                 {translate('NoLogFiles')}
-              </div>
+              </Alert>
           }
         </PageContentBody>
       </PageContent>

diff --git a/frontend/src/System/Updates/Updates.js b/frontend/src/System/Updates/Updates.js
@@ -1,6 +1,7 @@
 import _ from 'lodash';
 import PropTypes from 'prop-types';
 import React, { Component, Fragment } from 'react';
+import Alert from 'Components/Alert';
 import Icon from 'Components/Icon';
 import Label from 'Components/Label';
 import SpinnerButton from 'Components/Link/SpinnerButton';
@@ -61,9 +62,9 @@ class Updates extends Component {
 
           {
             noUpdates &&
-              <div>
+              <Alert kind={kinds.INFO}>
                 {translate('NoUpdatesAreAvailable')}
-              </div>
+              </Alert>
           }
 
           {

diff --git a/frontend/src/Wanted/CutoffUnmet/CutoffUnmet.js b/frontend/src/Wanted/CutoffUnmet/CutoffUnmet.js
@@ -1,5 +1,6 @@
 import PropTypes from 'prop-types';
 import React, { Component } from 'react';
+import Alert from 'Components/Alert';
 import LoadingIndicator from 'Components/Loading/LoadingIndicator';
 import FilterMenu from 'Components/Menu/FilterMenu';
 import ConfirmModal from 'Components/Modal/ConfirmModal';
@@ -190,16 +191,16 @@ class CutoffUnmet extends Component {
 
           {
             !isAnyFetching && error &&
-              <div>
+              <Alert kind={kinds.DANGER}>
                 Error fetching cutoff unmet
-              </div>
+              </Alert>
           }
 
           {
             isAllPopulated && !error && !items.length &&
-              <div>
-                No cutoff unmet items
-              </div>
+              <Alert kind={kinds.INFO}>
+                {translate('NoCutoffUnmetItems')}
+              </Alert>
           }
 
           {

diff --git a/frontend/src/Wanted/Missing/Missing.js b/frontend/src/Wanted/Missing/Missing.js
@@ -1,5 +1,6 @@
 import PropTypes from 'prop-types';
 import React, { Component } from 'react';
+import Alert from 'Components/Alert';
 import LoadingIndicator from 'Components/Loading/LoadingIndicator';
 import FilterMenu from 'Components/Menu/FilterMenu';
 import ConfirmModal from 'Components/Modal/ConfirmModal';
@@ -207,16 +208,16 @@ class Missing extends Component {
 
           {
             !isAnyFetching && error &&
-              <div>
+              <Alert kind={kinds.DANGER}>
                 Error fetching missing items
-              </div>
+              </Alert>
           }
 
           {
             isAllPopulated && !error && !items.length &&
-              <div>
-                No missing items
-              </div>
+              <Alert kind={kinds.INFO}>
+                {translate('NoMissingItems')}
+              </Alert>
           }
 
           {

diff --git a/src/NzbDrone.Core/Localization/Core/en.json b/src/NzbDrone.Core/Localization/Core/en.json
@@ -515,12 +515,15 @@
   "New": "New",
   "NewBooks": "New Books",
   "NoBackupsAreAvailable": "No backups are available",
+  "NoCutoffUnmetItems": "No cutoff unmet items",
+  "NoEventsFound": "No events found",
   "NoHistory": "No history.",
   "NoHistoryBlocklist": "No history blocklist",
   "NoLeaveIt": "No, Leave It",
   "NoLimitForAnyRuntime": "No limit for any runtime",
   "NoLogFiles": "No log files",
   "NoMinimumForAnyRuntime": "No minimum for any runtime",
+  "NoMissingItems": "No missing items",
   "NoName": "Do not show name",
   "NoTagsHaveBeenAddedYet": "No tags have been added yet. Add tags to link authors with delay profiles, restrictions, or notifications. Click {0} to find out more about tags in Readarr.",
   "NoUpdatesAreAvailable": "No updates are available",