Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full API Docs #15

Closed
RileyWilliams opened this issue Sep 16, 2016 · 18 comments
Closed

Full API Docs #15

RileyWilliams opened this issue Sep 16, 2016 · 18 comments
Assignees

Comments

@RileyWilliams
Copy link
Collaborator

Pycovjson needs full API docs.

@RileyWilliams RileyWilliams self-assigned this Sep 16, 2016
@lewismc
Copy link
Contributor

lewismc commented Sep 16, 2016

I've nearly done this. I'll send my pr tomorrow

On Sep 16, 2016 2:19 AM, "RileyWilliams" notifications@github.com wrote:

Pycovjson needs full API docs.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#15, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABHJl9lP6eAfX0joycXyNuhsGOqQ5AWbks5qql8OgaJpZM4J-vaJ
.

@RileyWilliams
Copy link
Collaborator Author

Okay, great! Are you using sphinx?

@lewismc
Copy link
Contributor

lewismc commented Sep 16, 2016

Yes. Idea would be to host them on RTFD. That sound good?

@RileyWilliams
Copy link
Collaborator Author

Yeah sounds good to me

@lewismc
Copy link
Contributor

lewismc commented Sep 16, 2016

Sound. I'll finish off what I have then send PR.

@RileyWilliams
Copy link
Collaborator Author

Thanks Lewis! Have made a few changes, such as removing a few unused files. Have also changed to use the RTD theme, but I am having issues with autodoc when building, did you come across this aswell?

@lewismc
Copy link
Contributor

lewismc commented Sep 23, 2016

Yeah there are a few issues... Ideally we would have API documentation
however I honestly junk there is just a minor tweak required in order to
get that.
If you navigate to Sphinx errors regarding automodule then you may get a
solution.
I'll try to have a look a wee bit later.

On Friday, September 23, 2016, RileyWilliams notifications@github.com
wrote:

Thanks Lewis! Have made a few changes, such as removing a few unused
files. Have also changed to use the RTD theme, but I am having issues with
autodoc when building, did you come across this aswell?


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#15 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABHJlytUyqYje6Ks08jS6SzDiRdtD5tMks5qs8_zgaJpZM4J-vaJ
.

Lewis
Dr. Lewis J. McGibbney Ph.D, B.Sc
Director
Phone: +1(626)498-3090
Skype: lewis.john.mcgibbney
Email: lewis.mcgibbney@gmail.com

@RileyWilliams
Copy link
Collaborator Author

I have been working on it today, will push changes I have made, think I am closing in on a solution.

@RileyWilliams
Copy link
Collaborator Author

Found the issue! Docs now compile correctly, am currently in the process of adding all of the methods to the documentation.

@lewismc
Copy link
Contributor

lewismc commented Sep 27, 2016

Nice @RileyWilliams will look forward to seeing what they actually look like. It would also be good to have these hosted on RTFD and a badge added to README.

@RileyWilliams
Copy link
Collaborator Author

Added badge, docs are not currently being generated properly on RTD however.

@lewismc
Copy link
Contributor

lewismc commented Sep 30, 2016

Cool you can log a ticket with rtfd and they will help you debug what is
going on.
This happens frequently.

On Friday, September 30, 2016, RileyWilliams notifications@github.com
wrote:

Added badge, docs are not currently being generated properly on RTD
however.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#15 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABHJl7rXvVtyRKRuUH7IB7l-OPiVKv3Tks5qvY1NgaJpZM4J-vaJ
.

Lewis
Dr. Lewis J. McGibbney Ph.D, B.Sc
Director
Phone: +1(626)498-3090
Skype: lewis.john.mcgibbney
Email: lewis.mcgibbney@gmail.com

@lewismc
Copy link
Contributor

lewismc commented Oct 4, 2016

I took a look at the docs and they look pretty good... the API documentation is not rendering correctly though. Did you log a ticket at RTFD's @RileyWilliams ?

@RileyWilliams
Copy link
Collaborator Author

I have finally diagnosed the issue, it is due to netCDF4 not installing correctly(shock). I am in the process of setting up conda with RTD, similar to how xarray do.

@RileyWilliams
Copy link
Collaborator Author

Pycovjson docs are now building correctly on RTD, work in progress version can be found here. Over the next few days I will add more detail to the docstrings and iron out the formatting errors which have occured.

@RileyWilliams
Copy link
Collaborator Author

Also, there is a small issue which may just be on my end where unless I clear my cache the page displays the old version. If anybody else experiences this issue let me know.

@lewismc
Copy link
Contributor

lewismc commented Oct 10, 2016

This is looking much much better. If I were you I would run make clean prior to running make html. That will ensure that the docs in build are newest.

@lewismc
Copy link
Contributor

lewismc commented Oct 18, 2016

@RileyWilliams this can be resolved IMHO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants