New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use size_t instead of unsigned in a bunch of appropriate places #425
Conversation
Once again, Travis tells us the build is fine when it's not. Boo. Hiss. |
This would theoretically break compatibility with apps using embedded classpaths, on big-endian architectures - because of the size type extension. However, we don't currently support any big-endian architectures, so it shouldn't be a problem.
Good thing you look at the output; I haven't been. When running ./test/ci.sh locally, it does what we want (fails on errors), so it's either travis's fault, or it's something weird we're doing in our configuration (.travis.yml). @sgoings, could you take a look? |
Actually, I'm able to reproduce this with test/ci.sh locally, too. It looks like it might be related to our use of && and || to do conditionals instead of if/then, with the result that when "make mode=debug bootimage=true test" fails, it doesn't error out of the script; it only skips the next item in the && chain. |
This seems to fix it:
I'll make a pull request. |
use size_t instead of unsigned in a bunch of appropriate places
I'm not sure how we didn't catch this when merging ReadyTalk#425, but there you are.
This would theoretically break compatibility with apps using embedded
classpaths, on big-endian architectures - because of the size type
extension. However, we don't currently support any big-endian
architectures, so it shouldn't be a problem.