ensure ci.sh exits with error when any test fails #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As explained in http://stackoverflow.com/questions/25794905/why-does-set-e-true-false-true-not-exit, "set -e" will only cause the script to exit if the failing command is "unhandled". The fancy || and && shortcuts we were using to run some of the tests caused bash to think we were handling the errors, which isn't what we wanted.
|
I'd hazard a guess to say that the first and third hunks aren't strictly necessary. However, do show a good example, and having that precedent in there ought to discourage further similar mistakes. FWIW, I wasn't seeing this locally because I wasn't actually making ci.sh fail how it was in #425. Good find! |
|
Checking the build output this time... And looks good! |
joshuawarner32
added a commit
that referenced
this pull request
Mar 16, 2015
ensure ci.sh exits with error when any test fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in
http://stackoverflow.com/questions/25794905/why-does-set-e-true-false-true-not-exit,
"set -e" will only cause the script to exit if the failing command is
"unhandled". The fancy || and && shortcuts we were using to run some
of the tests caused bash to think we were handling the errors, which
isn't what we wanted.
Fixes #416