PR for Creating investing page on crypto site #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankushdharkar
temporarily deployed
to
crypto-pipel-investing--odamc9
Rucha1499
force-pushed
the
investing-page
branch
from
e6cc10f
to
fc7f909
Compare
Rucha1499
changed the title
sumitd94
suggested changes
Mar 10, 2021
pages/invest/index.js
Outdated
| } | ||
| .shoppinglist-container { | ||
| display: flex; | ||
| flex-direction: row; |
There was a problem hiding this comment.
NIT: Not needed, by default it takes the direction as row
pages/invest/index.js
Outdated
Comment on lines
17
to
19
| {stock.map((itemName) => { | ||
| return <Card key={itemName} stock={stockData[itemName]} />; | ||
| })} |
There was a problem hiding this comment.
since you are returning only 1 line of code, you can transform this like this
{stock.map((itemName) => <Card key={itemName} stock={stockData[itemName]} />)}There was a problem hiding this comment.
I will do the changes. Thanks for the review😀
There was a problem hiding this comment.
May consider below to please the human eyes
{ stock.map( itemName => <Card key = {itemName} stock = { stockData[itemName] } />) }
Rucha1499
changed the title
swarajpure
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create an investing page where users can buys and sell stocks. Fixes #72
The input fields
stock NameandListed Priceare prefilled when clicked onBUY/SELLbuttons.Subsequent PRs - #186 - Adds validations for user login, wallet and enough money
