Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds validations for user login, wallet and enough money #186

Merged
merged 16 commits into from May 14, 2021
Merged

Adds validations for user login, wallet and enough money #186

merged 16 commits into from May 14, 2021

Conversation

Rucha1499
Copy link
Contributor

@Rucha1499 Rucha1499 commented Mar 18, 2021 •
edited

  • Created 2 different pages for buying and selling the stocks
  • Check added to confirm that the user is logged in before user trades stocks.
  • Checks added to see if user has wallet and enough money to buy/sell stocks

@Rucha1499 Rucha1499 added feature task A big ticket item that needs to come up as a feature frontend WIP This PR is still work in progress labels Mar 18, 2021
@ankushdharkar ankushdharkar temporarily deployed to crypto-pipel-feat-stock-lng91x March 18, 2021 09:42 Inactive
@ankushdharkar ankushdharkar temporarily deployed to crypto-pipel-feat-stock-lng91x March 18, 2021 10:03 Inactive
@ankushdharkar ankushdharkar temporarily deployed to crypto-pipel-feat-stock-lng91x March 21, 2021 09:46 Inactive
@ankushdharkar ankushdharkar temporarily deployed to crypto-pipel-feat-stock-lng91x March 22, 2021 17:32 Inactive
@ankushdharkar ankushdharkar temporarily deployed to crypto-pipel-feat-stock-lng91x March 22, 2021 18:46 Inactive
@ankushdharkar ankushdharkar temporarily deployed to crypto-pipel-feat-stock-lng91x March 23, 2021 08:16 Inactive
@ankushdharkar ankushdharkar temporarily deployed to crypto-pipel-feat-stock-lng91x March 23, 2021 18:56 Inactive
@ankushdharkar ankushdharkar temporarily deployed to crypto-pipel-feat-stock-lng91x March 25, 2021 18:27 Inactive
@Rucha1499 Rucha1499 removed the WIP This PR is still work in progress label Mar 25, 2021
@Rucha1499 Rucha1499 changed the title [WIP] PR for changes on trading page PR for changes on trading page Mar 25, 2021
sumitd94
sumitd94 suggested changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@sumitd94 sumitd94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job done 🥇
Few changes requested please.

components/stock-card/index.js Outdated Show resolved Hide resolved
components/stock-operation-modal/index.js Outdated Show resolved Hide resolved
components/stock-operation-modal/index.js Outdated Show resolved Hide resolved
components/stock-operation-modal/index.js Outdated Show resolved Hide resolved
@ankushdharkar ankushdharkar temporarily deployed to crypto-pipel-feat-stock-lng91x March 26, 2021 17:07 Inactive
@ankushdharkar ankushdharkar temporarily deployed to crypto-pipel-feat-stock-lng91x March 27, 2021 05:46 Inactive
@ankushdharkar ankushdharkar temporarily deployed to crypto-pipel-feat-stock-lng91x March 27, 2021 05:56 Inactive
@ankushdharkar ankushdharkar temporarily deployed to crypto-pipel-feat-stock-lng91x March 27, 2021 10:02 Inactive
ankushdharkar
ankushdharkar requested changes Apr 24, 2021
View reviewed changes
components/stock-operation-modal/index.js Outdated Show resolved Hide resolved
styles/Home.module.css Outdated Show resolved Hide resolved
redux/reducers/stocksDetails.js Show resolved Hide resolved
redux/action.js Outdated Show resolved Hide resolved
redux/action.js Show resolved Hide resolved
components/stock-card/index.js Outdated Show resolved Hide resolved
swarajpure
swarajpure reviewed May 12, 2021
View reviewed changes
styles/Home.module.css Outdated Show resolved Hide resolved
sumitd94
sumitd94 approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@sumitd94 sumitd94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, Appreciate your work here. Great job 🥇

swarajpure
swarajpure approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@swarajpure swarajpure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Great job! ⚡

@sumitd94 sumitd94 merged commit dfc8bd9 into develop May 14, 2021
@Rucha1499 Rucha1499 changed the title PR for changes on trading page Adds validations for user login, wallet and enough money Jun 12, 2021
@Rucha1499 Rucha1499 mentioned this pull request Jun 12, 2021
Merged
@swarajpure swarajpure deleted the feat/stocks-page branch June 25, 2021 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankushdharkar ankushdharkar ankushdharkar requested changes

@sumitd94 sumitd94 sumitd94 approved these changes

@swarajpure swarajpure swarajpure approved these changes

@whyDontI whyDontI Awaiting requested review from whyDontI

@SagarBajpai SagarBajpai Awaiting requested review from SagarBajpai

Assignees
No one assigned
Labels
feature task A big ticket item that needs to come up as a feature frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Rucha1499 @ankushdharkar @sumitd94 @swarajpure