Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task card improvements #554

Closed
4 of 15 tasks
skv93-coder opened this issue Jan 30, 2024 · 0 comments
Closed
4 of 15 tasks

Task card improvements #554

skv93-coder opened this issue Jan 30, 2024 · 0 comments
Assignees

Comments

@skv93-coder
Copy link
Contributor

skv93-coder commented Jan 30, 2024

Issue Description

When a user marks their task progress as 100% an unnecessary pop-up shows up.

Users need to click on the edit icon to update progress.

The user is never asked while changing the status of the task from 'In progress' to another status whether the progress of the task is 100 or not.

Expected Behavior

  1. Users, need not to click on the edit icon to update the progress bar and Hide unnecessary pop-ups which appear on marking the progress 100%.[Completed]

  2. On changing the status from 'In Progress' to any other status except 'Block' ask the user do they want to mark the progress of the current task as 100%

  3. On marking the progress 100% do not ask the user do they want to mark this task as 'Done' (as there are other statuses that are still possible).

After a discussion dated Feb 9 2024 with @ankushdharkar

The 2rd task changed to

  • If the user changes status from 'In progress' to any other status except 'Block' the progress of the task will be marked 100% and the user will be informed of this and provided a way to cancel the action.
  • If the user updates the task status from any status other than 'Block' to 'In progress' and the progress of the task is not 0, then the progress will be marked 0 and the user will be informed about this and provided a way to cancel the action.

After a discussion dated Feb 14 2024 with @ankushdharkar
If the user is on block status then if he tries to change the status to done. Inform him that the progress bar of the task will be marked 100.
Done status is final status.
You can not change from Done status to any other status.
The progress bar is only related to In progress status.

Related issue

The above tasks also resolve this issue. Where @satyam73 is unable to update progress after he has changed the status of the task from 'In progress'
and
also resolves this issue #568

Additional status found 03/03/24

Backlog, we are using it for handling task which are not on priority and their primary user is no longer on discord (My observation is this task status will not intersect with this issue.)
Merged, just like Verified status user is unable to update it. https://github.com/Real-Dev-Squad/website-backend/blob/dace8d7b2f342f304ca3cd737af1b8fdb821e2dc/controllers/tasks.js#L334

After talking with ankush on 04/03/24

Merged status should not be special status
Do not change flow of Backlog status

Conclusion/ User stories

  1. As a user, if my task status is done I should not be able to change status of the task.
  2. As a user, The progress bar should only be visible when my task is In progress.
  3. As a user, if I change my task status to In progress from any status other than Block and my current progress is not 0%. then, I should get a modal informing me that proceeding further will make progress 0%.
  4. As a user, if I try to change my status from In progress to any status other than Block and my progress is not 100 I should get a modal informing me that proceeding further will make progress 100%.
  5. As a user, If my task is on Block status and progress is not 100% then on change of task to In progress should happen without a change in the progress level of the progress bar..
  6. As a user, If my task is on Block status and progress is not 100%. then, on change of task to any status other than In progress I should get a modal informing that proceeding further will make progress 100%.

Current Behavior

Screenshots

screen-capture.5.webm

Reproducibility

  • This issue is reproducible
  • This issue is not reproducible

Steps to Reproduce

Severity/Priority

  • Critical
  • High
  • Medium
  • Low

Additional Information

Checklist

  • I have read and followed the project's code of conduct.
  • I have searched for similar issues before creating this one.
  • I have provided all the necessary information to understand and reproduce the issue.
  • I am willing to contribute to the resolution of this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant