-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update query param on issues tab url based on search query #989
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The query should persist in the search bar after sharing.
- The API should be
search?q=dark%20mode
orsearch?q=dark+mode
(That's what Google use)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You haven't added a test case to verify whether the changes are actually reflected in the search URL or not when the input field is changed.
Please add tests for your feature. |
For this case, it looks good. |
…tatus into feat/update-query-params
…tatus into feat/update-query-params
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, regarding this comment of yours Gaurav : #989 (review) |
If the behaviour is same, after making your changes then it's fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Developer name : @j24m
Backend Changes :
Frontend changes :
Is Under Feature Flag :
Database changes :
Breaking changes :
Tested on local :
Issue :
Description :
Code Changes :
Anything you would like to inform the reviewer about:
Dev Tested :
Test Stats :
Images/video of the change :
20231107_182540.mp4
Follow-up Issues (if any) :