New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/profile-pic #168
Feature/profile-pic #168
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR @shetty-shithil 😃
Added a comment. Kindly check it. Also, your PR seems to have a lot of unnecessary formatting changes. Please have a look at that. Make sure you have the latest code before you do changes!
Thank you.
const url = "https://api.realdevsquad.com/users/self"; | ||
function setPhoto(username) { | ||
if (username) { | ||
const userImgEl = document.querySelector('.user-profile-pic'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have a more elaborative variable name here?
No work on this PR since a long time. The page for which this feature was to be created has major changes in design. Once its fixed, new issue and PR can be raised for this feature. |
* add tests for new signup flow (#149) * Added Component test * Added Ember Addon * Added controller test * Removed extra fields * add update profile page form (#150) * added functionality to update profile info * disabled name fields * Removed "required" property from all fields * Renamed labels for some fields * Fixed 'yoe' issue to treat it as number * Fixed the redirection * Added link to upload component in profile page (#156) * Added link to uplaod component in profile page * Fix styling Co-authored-by: Prakash <you@example.com> * Added test to ensure return type from FormInput component #129 (#130) * Move tests for the new component from FormInput to InputField (#168) * chore: tests for new component input-field * Create InputField component for input field with type validation (#169) * feat: create new component InputField for input fields with type validation * chore: move from Input component to native html input and add styles * chore: remove validator, change em to rem, remove class repetition * styles: remove important rule and remove outline * Add slider to task updation form (#166) * Slider added * changed staging-api to api in env.js * chore: remove dummy json for tasks, refactor code * chore: remove outline:none css and remove list status attribute * chore: fix package-lock * chore: add css variable for slider thumb background Co-authored-by: Devashish Joshi <VaingloryIsGreat@gmail.com> Co-authored-by: Lakshay Manchanda <45519620+lakshayman@users.noreply.github.com> Co-authored-by: Rohan Raj Gupta <78433013+rohan09-raj@users.noreply.github.com> Co-authored-by: Prakash Choudhary <34452139+prakashchoudhary07@users.noreply.github.com> Co-authored-by: Prakash <you@example.com> Co-authored-by: Ankush Dharkar <ankushdharkar@users.noreply.github.com> Co-authored-by: Devashish Joshi <VaingloryIsGreat@gmail.com>
* add tests for new signup flow (#149) * Added Component test * Added Ember Addon * Added controller test * Removed extra fields * add update profile page form (#150) * added functionality to update profile info * disabled name fields * Removed "required" property from all fields * Renamed labels for some fields * Fixed 'yoe' issue to treat it as number * Fixed the redirection * Added link to upload component in profile page (#156) * Added link to uplaod component in profile page * Fix styling Co-authored-by: Prakash <you@example.com> * Added test to ensure return type from FormInput component #129 (#130) * Move tests for the new component from FormInput to InputField (#168) * chore: tests for new component input-field * Create InputField component for input field with type validation (#169) * feat: create new component InputField for input fields with type validation * chore: move from Input component to native html input and add styles * chore: remove validator, change em to rem, remove class repetition * styles: remove important rule and remove outline * Add slider to task updation form (#166) * Slider added * changed staging-api to api in env.js * chore: remove dummy json for tasks, refactor code * chore: remove outline:none css and remove list status attribute * chore: fix package-lock * chore: add css variable for slider thumb background Co-authored-by: Devashish Joshi <VaingloryIsGreat@gmail.com> * Bump tmpl from 1.0.4 to 1.0.5 (#172) Bumps [tmpl](https://github.com/daaku/nodejs-tmpl) from 1.0.4 to 1.0.5. - [Release notes](https://github.com/daaku/nodejs-tmpl/releases) - [Commits](https://github.com/daaku/nodejs-tmpl/commits/v1.0.5) --- updated-dependencies: - dependency-name: tmpl dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump path-parse from 1.0.6 to 1.0.7 (#173) Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7. - [Release notes](https://github.com/jbgutierrez/path-parse/releases) - [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7) --- updated-dependencies: - dependency-name: path-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * hide navbar for signup page (#159) Co-authored-by: sushanth97 <sushanth.s@zohocorp.com> Co-authored-by: Lakshay Manchanda <45519620+lakshayman@users.noreply.github.com> Co-authored-by: Rohan Raj Gupta <78433013+rohan09-raj@users.noreply.github.com> Co-authored-by: Prakash Choudhary <34452139+prakashchoudhary07@users.noreply.github.com> Co-authored-by: Prakash <you@example.com> Co-authored-by: Ankush Dharkar <ankushdharkar@users.noreply.github.com> Co-authored-by: Devashish Joshi <VaingloryIsGreat@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: sushanth97 <38094208+sushanth97@users.noreply.github.com> Co-authored-by: sushanth97 <sushanth.s@zohocorp.com>
* add tests for new signup flow (#149) * Added Component test * Added Ember Addon * Added controller test * Removed extra fields * add update profile page form (#150) * added functionality to update profile info * disabled name fields * Removed "required" property from all fields * Renamed labels for some fields * Fixed 'yoe' issue to treat it as number * Fixed the redirection * Added link to upload component in profile page (#156) * Added link to uplaod component in profile page * Fix styling Co-authored-by: Prakash <you@example.com> * Added test to ensure return type from FormInput component #129 (#130) * Move tests for the new component from FormInput to InputField (#168) * chore: tests for new component input-field * Create InputField component for input field with type validation (#169) * feat: create new component InputField for input fields with type validation * chore: move from Input component to native html input and add styles * chore: remove validator, change em to rem, remove class repetition * styles: remove important rule and remove outline Co-authored-by: Lakshay Manchanda <45519620+lakshayman@users.noreply.github.com> Co-authored-by: Rohan Raj Gupta <78433013+rohan09-raj@users.noreply.github.com> Co-authored-by: Prakash Choudhary <34452139+prakashchoudhary07@users.noreply.github.com> Co-authored-by: Prakash <you@example.com> Co-authored-by: Ankush Dharkar <ankushdharkar@users.noreply.github.com>
* add tests for new signup flow (#149) * Added Component test * Added Ember Addon * Added controller test * Removed extra fields * add update profile page form (#150) * added functionality to update profile info * disabled name fields * Removed "required" property from all fields * Renamed labels for some fields * Fixed 'yoe' issue to treat it as number * Fixed the redirection * Added link to upload component in profile page (#156) * Added link to uplaod component in profile page * Fix styling Co-authored-by: Prakash <you@example.com> * updating user status feature * Simplified the user status component logic * Fix for the failing test * Added a pointer on button and some spacing fixes. * updated package lock version * Added test to ensure return type from FormInput component #129 (#130) * Move tests for the new component from FormInput to InputField (#168) * chore: tests for new component input-field * Create InputField component for input field with type validation (#169) * feat: create new component InputField for input fields with type validation * chore: move from Input component to native html input and add styles * chore: remove validator, change em to rem, remove class repetition * styles: remove important rule and remove outline * Handled edge cases for user status * Fixed naming and handled a edge-case in handlebars * handled edge case - when user not logged in * removed non-required fields in UserStatusComponent * Added disabled attribute to user-status buttons * Added finally block * Fixed backticks * chore: resolve conflicts Co-authored-by: Lakshay Manchanda <45519620+lakshayman@users.noreply.github.com> Co-authored-by: Rohan Raj Gupta <78433013+rohan09-raj@users.noreply.github.com> Co-authored-by: Prakash Choudhary <34452139+prakashchoudhary07@users.noreply.github.com> Co-authored-by: Prakash <you@example.com> Co-authored-by: Rohan Raj Gupta <rajrohan1914@gmail.com> Co-authored-by: Ankush Dharkar <ankushdharkar@users.noreply.github.com>
* Feature: marking user status (#182) * add tests for new signup flow (#149) * Added Component test * Added Ember Addon * Added controller test * Removed extra fields * add update profile page form (#150) * added functionality to update profile info * disabled name fields * Removed "required" property from all fields * Renamed labels for some fields * Fixed 'yoe' issue to treat it as number * Fixed the redirection * Added link to upload component in profile page (#156) * Added link to uplaod component in profile page * Fix styling Co-authored-by: Prakash <you@example.com> * Added test to ensure return type from FormInput component #129 (#130) * Move tests for the new component from FormInput to InputField (#168) * chore: tests for new component input-field * Create InputField component for input field with type validation (#169) * feat: create new component InputField for input fields with type validation * chore: move from Input component to native html input and add styles * chore: remove validator, change em to rem, remove class repetition * styles: remove important rule and remove outline Co-authored-by: Lakshay Manchanda <45519620+lakshayman@users.noreply.github.com> Co-authored-by: Rohan Raj Gupta <78433013+rohan09-raj@users.noreply.github.com> Co-authored-by: Prakash Choudhary <34452139+prakashchoudhary07@users.noreply.github.com> Co-authored-by: Prakash <you@example.com> Co-authored-by: Ankush Dharkar <ankushdharkar@users.noreply.github.com> * Feature: updating user status (#183) * add tests for new signup flow (#149) * Added Component test * Added Ember Addon * Added controller test * Removed extra fields * add update profile page form (#150) * added functionality to update profile info * disabled name fields * Removed "required" property from all fields * Renamed labels for some fields * Fixed 'yoe' issue to treat it as number * Fixed the redirection * Added link to upload component in profile page (#156) * Added link to uplaod component in profile page * Fix styling Co-authored-by: Prakash <you@example.com> * updating user status feature * Simplified the user status component logic * Fix for the failing test * Added a pointer on button and some spacing fixes. * updated package lock version * Added test to ensure return type from FormInput component #129 (#130) * Move tests for the new component from FormInput to InputField (#168) * chore: tests for new component input-field * Create InputField component for input field with type validation (#169) * feat: create new component InputField for input fields with type validation * chore: move from Input component to native html input and add styles * chore: remove validator, change em to rem, remove class repetition * styles: remove important rule and remove outline * Handled edge cases for user status * Fixed naming and handled a edge-case in handlebars * handled edge case - when user not logged in * removed non-required fields in UserStatusComponent * Added disabled attribute to user-status buttons * Added finally block * Fixed backticks * chore: resolve conflicts Co-authored-by: Lakshay Manchanda <45519620+lakshayman@users.noreply.github.com> Co-authored-by: Rohan Raj Gupta <78433013+rohan09-raj@users.noreply.github.com> Co-authored-by: Prakash Choudhary <34452139+prakashchoudhary07@users.noreply.github.com> Co-authored-by: Prakash <you@example.com> Co-authored-by: Rohan Raj Gupta <rajrohan1914@gmail.com> Co-authored-by: Ankush Dharkar <ankushdharkar@users.noreply.github.com> Co-authored-by: Lakshay Manchanda <45519620+lakshayman@users.noreply.github.com> Co-authored-by: Rohan Raj Gupta <78433013+rohan09-raj@users.noreply.github.com> Co-authored-by: Prakash Choudhary <34452139+prakashchoudhary07@users.noreply.github.com> Co-authored-by: Prakash <you@example.com> Co-authored-by: Ankush Dharkar <ankushdharkar@users.noreply.github.com> Co-authored-by: Rohan Raj Gupta <rajrohan1914@gmail.com>
* add tests for new signup flow (#149) * Added Component test * Added Ember Addon * Added controller test * Removed extra fields * add update profile page form (#150) * added functionality to update profile info * disabled name fields * Removed "required" property from all fields * Renamed labels for some fields * Fixed 'yoe' issue to treat it as number * Fixed the redirection * Added link to upload component in profile page (#156) * Added link to uplaod component in profile page * Fix styling Co-authored-by: Prakash <you@example.com> * Added test to ensure return type from FormInput component #129 (#130) * added loading state for tasks route * Move tests for the new component from FormInput to InputField (#168) * chore: tests for new component input-field * Create InputField component for input field with type validation (#169) * feat: create new component InputField for input fields with type validation * chore: move from Input component to native html input and add styles * chore: remove validator, change em to rem, remove class repetition * styles: remove important rule and remove outline * package-lock udpate * added loading state for tasks route * package-lock changed * loading state for profile * loading file added * package-lock resolved conflicts * loading spinner added * spinner centered Co-authored-by: Lakshay Manchanda <45519620+lakshayman@users.noreply.github.com> Co-authored-by: Rohan Raj Gupta <78433013+rohan09-raj@users.noreply.github.com> Co-authored-by: Prakash Choudhary <34452139+prakashchoudhary07@users.noreply.github.com> Co-authored-by: Prakash <you@example.com> Co-authored-by: Ankush Dharkar <ankushdharkar@users.noreply.github.com> Co-authored-by: Swaraj Rajpure <56217868+swarajpure@users.noreply.github.com>
* Feature: marking user status (#182) * add tests for new signup flow (#149) * Added Component test * Added Ember Addon * Added controller test * Removed extra fields * add update profile page form (#150) * added functionality to update profile info * disabled name fields * Removed "required" property from all fields * Renamed labels for some fields * Fixed 'yoe' issue to treat it as number * Fixed the redirection * Added link to upload component in profile page (#156) * Added link to uplaod component in profile page * Fix styling Co-authored-by: Prakash <you@example.com> * Added test to ensure return type from FormInput component #129 (#130) * Move tests for the new component from FormInput to InputField (#168) * chore: tests for new component input-field * Create InputField component for input field with type validation (#169) * feat: create new component InputField for input fields with type validation * chore: move from Input component to native html input and add styles * chore: remove validator, change em to rem, remove class repetition * styles: remove important rule and remove outline Co-authored-by: Lakshay Manchanda <45519620+lakshayman@users.noreply.github.com> Co-authored-by: Rohan Raj Gupta <78433013+rohan09-raj@users.noreply.github.com> Co-authored-by: Prakash Choudhary <34452139+prakashchoudhary07@users.noreply.github.com> Co-authored-by: Prakash <you@example.com> Co-authored-by: Ankush Dharkar <ankushdharkar@users.noreply.github.com> * Feature: updating user status (#183) * add tests for new signup flow (#149) * Added Component test * Added Ember Addon * Added controller test * Removed extra fields * add update profile page form (#150) * added functionality to update profile info * disabled name fields * Removed "required" property from all fields * Renamed labels for some fields * Fixed 'yoe' issue to treat it as number * Fixed the redirection * Added link to upload component in profile page (#156) * Added link to uplaod component in profile page * Fix styling Co-authored-by: Prakash <you@example.com> * updating user status feature * Simplified the user status component logic * Fix for the failing test * Added a pointer on button and some spacing fixes. * updated package lock version * Added test to ensure return type from FormInput component #129 (#130) * Move tests for the new component from FormInput to InputField (#168) * chore: tests for new component input-field * Create InputField component for input field with type validation (#169) * feat: create new component InputField for input fields with type validation * chore: move from Input component to native html input and add styles * chore: remove validator, change em to rem, remove class repetition * styles: remove important rule and remove outline * Handled edge cases for user status * Fixed naming and handled a edge-case in handlebars * handled edge case - when user not logged in * removed non-required fields in UserStatusComponent * Added disabled attribute to user-status buttons * Added finally block * Fixed backticks * chore: resolve conflicts Co-authored-by: Lakshay Manchanda <45519620+lakshayman@users.noreply.github.com> Co-authored-by: Rohan Raj Gupta <78433013+rohan09-raj@users.noreply.github.com> Co-authored-by: Prakash Choudhary <34452139+prakashchoudhary07@users.noreply.github.com> Co-authored-by: Prakash <you@example.com> Co-authored-by: Rohan Raj Gupta <rajrohan1914@gmail.com> Co-authored-by: Ankush Dharkar <ankushdharkar@users.noreply.github.com> * loading state for routes (#164) * add tests for new signup flow (#149) * Added Component test * Added Ember Addon * Added controller test * Removed extra fields * add update profile page form (#150) * added functionality to update profile info * disabled name fields * Removed "required" property from all fields * Renamed labels for some fields * Fixed 'yoe' issue to treat it as number * Fixed the redirection * Added link to upload component in profile page (#156) * Added link to uplaod component in profile page * Fix styling Co-authored-by: Prakash <you@example.com> * Added test to ensure return type from FormInput component #129 (#130) * added loading state for tasks route * Move tests for the new component from FormInput to InputField (#168) * chore: tests for new component input-field * Create InputField component for input field with type validation (#169) * feat: create new component InputField for input fields with type validation * chore: move from Input component to native html input and add styles * chore: remove validator, change em to rem, remove class repetition * styles: remove important rule and remove outline * package-lock udpate * added loading state for tasks route * package-lock changed * loading state for profile * loading file added * package-lock resolved conflicts * loading spinner added * spinner centered Co-authored-by: Lakshay Manchanda <45519620+lakshayman@users.noreply.github.com> Co-authored-by: Rohan Raj Gupta <78433013+rohan09-raj@users.noreply.github.com> Co-authored-by: Prakash Choudhary <34452139+prakashchoudhary07@users.noreply.github.com> Co-authored-by: Prakash <you@example.com> Co-authored-by: Ankush Dharkar <ankushdharkar@users.noreply.github.com> Co-authored-by: Swaraj Rajpure <56217868+swarajpure@users.noreply.github.com> Co-authored-by: Lakshay Manchanda <45519620+lakshayman@users.noreply.github.com> Co-authored-by: Rohan Raj Gupta <78433013+rohan09-raj@users.noreply.github.com> Co-authored-by: Prakash Choudhary <34452139+prakashchoudhary07@users.noreply.github.com> Co-authored-by: Prakash <you@example.com> Co-authored-by: Ankush Dharkar <ankushdharkar@users.noreply.github.com> Co-authored-by: Rohan Raj Gupta <rajrohan1914@gmail.com> Co-authored-by: Akshay Shinde <55057874+akshay1502@users.noreply.github.com>
* add tests for new signup flow (#149) * Added Component test * Added Ember Addon * Added controller test * Removed extra fields * add update profile page form (#150) * added functionality to update profile info * disabled name fields * Removed "required" property from all fields * Renamed labels for some fields * Fixed 'yoe' issue to treat it as number * Fixed the redirection * Added link to upload component in profile page (#156) * Added link to uplaod component in profile page * Fix styling Co-authored-by: Prakash <you@example.com> * Added test to ensure return type from FormInput component #129 (#130) * Move tests for the new component from FormInput to InputField (#168) * chore: tests for new component input-field * Create InputField component for input field with type validation (#169) * feat: create new component InputField for input fields with type validation * chore: move from Input component to native html input and add styles * chore: remove validator, change em to rem, remove class repetition * styles: remove important rule and remove outline Co-authored-by: Lakshay Manchanda <45519620+lakshayman@users.noreply.github.com> Co-authored-by: Rohan Raj Gupta <78433013+rohan09-raj@users.noreply.github.com> Co-authored-by: Prakash Choudhary <34452139+prakashchoudhary07@users.noreply.github.com> Co-authored-by: Prakash <you@example.com> Co-authored-by: Ankush Dharkar <ankushdharkar@users.noreply.github.com>
I've added the profile-pic besides greeting message.