re-designed header and nav bar #175

ghosharnab969 · 2021-08-10T17:55:59Z

previous design :

new design :

harshith-venkatesh · 2021-08-11T19:08:22Z

css/pages/index.css

+}
+#first-line {
+  font-size: 4.3em;
+  line-height: -3em;


What is thr purpose of negetive libe height

I have removed the line-height attribute, thank you for your review!

harshith-venkatesh · 2021-08-11T19:09:37Z

css/pages/index.css

+  left: 0.8em;
+}
+#welcome-text {
+  font-family: 'raleway';


Is there a way we can wrap a div with a font family instead of repetition

yes, there is definitely, and I am done correcting it. Thankyou!

index.html

Rucha1499 · 2021-08-16T06:05:43Z

css/pages/index.css

+/* Arnab's code */
+body {
+  margin: 0;
+}


Kindly leave one line after writing CSS for a class/id. Code will not look crowded that way! 😃

We don't comment that it is our code
GitHub lens automatically mentions in whose comments these changes are committed

Harshith actually we kept the old css for now we will remove it while integrating all the components of the screen

I am mentioning line 5 here

Kindly leave one line after writing CSS for a class/id. Code will not look crowded that way! 😃

I have corrected the code.

harshith-venkatesh · 2021-08-16T06:13:47Z

css/pages/index.css

+/* Arnab's code */
+body {
+  margin: 0;
+}


We don't comment that it is our code
GitHub lens automatically mentions in whose comments these changes are committed

harshith-venkatesh · 2021-08-16T06:15:06Z

index.html

+    </div>
+    <div class="second-screen"></div>
+    <div class="third-screen"></div>
+    <!-- <header> -->


Comments can be removed if we are not using it

Comments can be removed if we are not using it

sure, comments have been removed from the code. Thankyou!

Pujarini · 2021-08-16T15:38:00Z

css/pages/index.css

+  height: 2.8rem;
+  background: linear-gradient(130deg, #f3036b, #dc7faf, #e30062);
+  color: #091133;
+  font-family: 'poppins';


Please use shorthand for font
https://developer.mozilla.org/en-US/docs/Web/CSS/font

Please use shorthand for font
https://developer.mozilla.org/en-US/docs/Web/CSS/font

I have corrected the code and used short-hand wherever possible. In some places using font short-hand is leading to repetition of code, so I have left those sections unchanged!

Pujarini · 2021-08-16T15:41:22Z

css/pages/index.css

+}
+#to-theTxt {
+  font-family: 'raleway';
+  color: #fff;


use shorthand for font here too.

Pujarini · 2021-08-16T15:41:39Z

css/pages/index.css

+}
+#realDevSquadTxt {
+  color: #fff;
+  font-family: 'raleway';


shorthand for font here too

Pujarini · 2021-08-16T15:42:55Z

css/pages/index.css

+}
+div.heading-container {
+  flex-direction: column;
+  display: inline-block;


display is inline-block but you are using flex-direction? Why so?

display is inline-block but you are using flex-direction? Why so?

It seems I forgot to delete the flex-direction property while manipulating the code. Anyways, I have fixed the issue now! 😊

Pujarini · 2021-08-16T15:44:20Z

index.html

+            class="nav-text member"
+            href="https://www.google.com"
+            target="_blank"
+            >Member</a


Add the actual routes

Add the actual routes
actual routes added!

Rucha1499

@ghosharnab969 Which file is this? I am not able to open it. Can you check please if it is needed or not?

ghosharnab969 · 2021-08-27T05:18:33Z

@ghosharnab969 Which file is this? I am not able to open it. Can you check please if it is needed or not?

Is this file present in the RDS repo? It seems I have not added this file on purpose!

Rucha1499 · 2021-08-28T17:26:17Z

index.html

+      <div class="news-feeds-container">
+        <div class="new-tag">New</div>
+        1 Year Aniversary--New Features Available for YOU!
+        <a id="checkout-tag" href="https://www.google.com">Check them out </a>


Can we have this link replaced by this? https://www.realdevsquad.com/releases

Can we have this link replaced by this? https://www.realdevsquad.com/releases

sure!

Rucha1499

Great work! @ghosharnab969 🎉

Revert "re-designed header and nav bar" PR - #175

* add tests for new signup flow (#149) * Added Component test * Added Ember Addon * Added controller test * Removed extra fields * add update profile page form (#150) * added functionality to update profile info * disabled name fields * Removed "required" property from all fields * Renamed labels for some fields * Fixed 'yoe' issue to treat it as number * Fixed the redirection * Added link to upload component in profile page (#156) * Added link to uplaod component in profile page * Fix styling Co-authored-by: Prakash <you@example.com> * Added test to ensure return type from FormInput component #129 (#130) * Move tests for the new component from FormInput to InputField (#168) * chore: tests for new component input-field * Create InputField component for input field with type validation (#169) * feat: create new component InputField for input fields with type validation * chore: move from Input component to native html input and add styles * chore: remove validator, change em to rem, remove class repetition * styles: remove important rule and remove outline * Add slider to task updation form (#166) * Slider added * changed staging-api to api in env.js * chore: remove dummy json for tasks, refactor code * chore: remove outline:none css and remove list status attribute * chore: fix package-lock * chore: add css variable for slider thumb background Co-authored-by: Devashish Joshi <VaingloryIsGreat@gmail.com> * Bump tmpl from 1.0.4 to 1.0.5 (#172) Bumps [tmpl](https://github.com/daaku/nodejs-tmpl) from 1.0.4 to 1.0.5. - [Release notes](https://github.com/daaku/nodejs-tmpl/releases) - [Commits](https://github.com/daaku/nodejs-tmpl/commits/v1.0.5) --- updated-dependencies: - dependency-name: tmpl dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump path-parse from 1.0.6 to 1.0.7 (#173) Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7. - [Release notes](https://github.com/jbgutierrez/path-parse/releases) - [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7) --- updated-dependencies: - dependency-name: path-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * hide navbar for signup page (#159) Co-authored-by: sushanth97 <sushanth.s@zohocorp.com> Co-authored-by: Lakshay Manchanda <45519620+lakshayman@users.noreply.github.com> Co-authored-by: Rohan Raj Gupta <78433013+rohan09-raj@users.noreply.github.com> Co-authored-by: Prakash Choudhary <34452139+prakashchoudhary07@users.noreply.github.com> Co-authored-by: Prakash <you@example.com> Co-authored-by: Ankush Dharkar <ankushdharkar@users.noreply.github.com> Co-authored-by: Devashish Joshi <VaingloryIsGreat@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: sushanth97 <38094208+sushanth97@users.noreply.github.com> Co-authored-by: sushanth97 <sushanth.s@zohocorp.com>

ghosharnab969 added 2 commits August 10, 2021 23:15

re-designed header and nav bar

6ea498a

final changes for header and navbar made

ba1f211

harshith-venkatesh suggested changes Aug 11, 2021

View reviewed changes

requested changes made

3ca51d8

ghosharnab969 requested a review from harshith-venkatesh August 12, 2021 05:58

Rucha1499 reviewed Aug 16, 2021

View reviewed changes

harshith-venkatesh suggested changes Aug 16, 2021

View reviewed changes

Pujarini suggested changes Aug 16, 2021

View reviewed changes

made requested changes to he code

62887eb

ghosharnab969 requested a review from Pujarini August 16, 2021 17:15

ghosharnab969 added 3 commits August 23, 2021 08:43

commented code removed

6abed25

navbar contens styling enhanced

7044079

hover effect given to nav contents

1cb4267

Rucha1499 reviewed Aug 25, 2021

View reviewed changes

unwanted file removed

32486c3

ghosharnab969 requested a review from harshith-venkatesh August 27, 2021 05:29

Rucha1499 suggested changes Aug 28, 2021

View reviewed changes

added link to new-feeds container

0a20895

ghosharnab969 requested a review from Rucha1499 August 29, 2021 06:06

Rucha1499 approved these changes Aug 29, 2021

View reviewed changes

Rucha1499 merged commit c4dbf48 into Real-Dev-Squad:develop Aug 29, 2021

Rucha1499 mentioned this pull request Aug 29, 2021

Revert "re-designed header and nav bar" PR - #175 #182

Merged

Rucha1499 added a commit that referenced this pull request Aug 29, 2021

Merge pull request #182 from Real-Dev-Squad/revert-175-feat/login-header

00262ca

Revert "re-designed header and nav bar" PR - #175

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

re-designed header and nav bar #175

re-designed header and nav bar #175

ghosharnab969 commented Aug 10, 2021

harshith-venkatesh Aug 11, 2021

ghosharnab969 Aug 11, 2021

harshith-venkatesh Aug 11, 2021

ghosharnab969 Aug 11, 2021 •

edited

Rucha1499 Aug 16, 2021

harshith-venkatesh Aug 16, 2021

Pujarini Aug 16, 2021

harshith-venkatesh Aug 16, 2021

ghosharnab969 Aug 16, 2021

harshith-venkatesh Aug 16, 2021

harshith-venkatesh Aug 16, 2021

ghosharnab969 Aug 27, 2021

Pujarini Aug 16, 2021

ghosharnab969 Aug 16, 2021

Pujarini Aug 16, 2021

Pujarini Aug 16, 2021

Pujarini Aug 16, 2021

ghosharnab969 Aug 16, 2021 •

edited

Pujarini Aug 16, 2021

ghosharnab969 Aug 17, 2021

Rucha1499 left a comment

ghosharnab969 commented Aug 27, 2021

Rucha1499 Aug 28, 2021

ghosharnab969 Aug 29, 2021 •

edited

Rucha1499 left a comment

re-designed header and nav bar #175

re-designed header and nav bar #175

Conversation

ghosharnab969 commented Aug 10, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghosharnab969 Aug 11, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghosharnab969 Aug 16, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Rucha1499 left a comment

Choose a reason for hiding this comment

ghosharnab969 commented Aug 27, 2021

Choose a reason for hiding this comment

ghosharnab969 Aug 29, 2021 • edited

Choose a reason for hiding this comment

Rucha1499 left a comment

Choose a reason for hiding this comment

ghosharnab969 Aug 11, 2021 •

edited

ghosharnab969 Aug 16, 2021 •

edited

ghosharnab969 Aug 29, 2021 •

edited