-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added changes for resdesign of welcome site #177
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the .DS_Store
files, those seem to unnecessary
Added few comments for CSS, please check
Great job in here! 🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove the .DS_Store
files?
re-designed header and nav bar
Revert "re-designed header and nav bar" PR - #175
Indeed (y) |
* added a link for a particular FAQ * removed inline style to class * renamed the class * renamed the class * renamed the class * formatted with prettier * simplified js code * modified js code * simplified js code * removed unnecessary console logs * modified js code * modified js code * button content is made empty and set using css * removed the inner loop which was used to handle the button inner content * added pseudo selectors on button * removed the unused id * added the vairable for expand button icon
* changes to my owm repo * responsive welcome website * JS file modified * Conflicts resolved * final changes to CSS made * changes to CSS made * changes to my owm repo * responsive welcome website * JS file modified * Conflicts resolved * final changes to CSS made * changes to CSS made * files changed * pictures added * changes to my owm repo * merge conflicts resolved * Conflicts resolved * changes to CSS made * pictures added * renamed files * deleted unwanted pic folder * corrected backward slashes * unutilized classes removed * Js variable names changed * added ref * removed target * added target to navbar * spelling changes made
* merged first and second screen * added shorthand css properties * added class to h3 * merged first and second screen
✔️ Deploy Preview for staging-welcome ready! 🔨 Explore the source changes: 6279d37 🔍 Inspect the deploy log: https://app.netlify.com/sites/staging-welcome/deploys/61893d5311e2fb000793b9b3 😎 Browse the preview: https://deploy-preview-177--staging-welcome.netlify.app |
✔️ Deploy Preview for staging-welcome-site ready! 🔨 Explore the source changes: 6279d37 🔍 Inspect the deploy log: https://app.netlify.com/sites/staging-welcome-site/deploys/61893d5315b45d00070cd391 😎 Browse the preview: https://deploy-preview-177--staging-welcome-site.netlify.app |
Can you please add screenshots of the updated screen @Pujarini |
@Ishikabaid Find screenshot here for removed underline |
Made required changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Job!🎉
Desktop version:
https://user-images.githubusercontent.com/34391629/140087591-7ab43302-de33-459c-b325-bb5663e6b7a5.mov
Mobile version :
mobile-view.mov