Skip to content

Thunderbird 102 - current category is not remembered / selected #279

Closed

Description

@RealRaven2000

When restarting Thunderbird, all categories are selected so that all tabs are selected. I would expect each tab to remember it's category as before.

Activity

  1. self-assigned this
    on Jul 1, 2022
  2. pinned this issue on Jul 7, 2022
  3. RealRaven2000 commented on Jul 16, 2022

    @RealRaven2000
    OwnerAuthor

    Here is a first patch that works reasonably well:

    QuickFolders-mx-5.11pre70.zip

    This version stores its own session information whenever a new tab is opened / selected / deleted / moved in the current window. It also restores reliably in most cases. It doesn't keep track of multiple windows, so if you open a second and third window and change tabs there and then close them this version may not store the correct category information. For it to work in that case I need to also find an event for when the "Main" (if there is a main) window is focused and store the tabSession again (in case it was overwritten by other windows). I also don't currently know which window is restored when Thunderbird closes all windows because a user selected "close all windows" from the taskbar or shuts down the OS causing the windows to be closed. I consider these as edge cases for the moment.

    To see what's happening behind the scenes with the session, enabled Debug mode (from QF advanced settings) and then filter the error console for loadTabSession or storeTabSession.

  4. added a commit that references this issue on Jul 16, 2022
  5. RealRaven2000 commented on Jul 17, 2022

    @RealRaven2000
    OwnerAuthor

    Fixed some code that stores wrong categories when folder is opened in a new tab or a folder / message tab is closed that is currently not selected:

    QuickFolders-mx-5.11pre75.zip

    As always, to install this version please download the zip file and drag it into Thunderbird Add-ons Manager (without unpacking)

  6. RealRaven2000 commented on Jul 19, 2022

    @RealRaven2000
    OwnerAuthor

    Fixed a problem with invalid categories staying in the tab session forever. Now on every categorySelect() call we check for validity of the first category. To do: do a full test with multiple category selection.

    QuickFolders-mx-5.11pre89.zip

    As always, to install this version please download the zip file and drag it into Thunderbird Add-ons Manager (without unpacking)

  7. RealRaven2000 commented on Jul 20, 2022

    @RealRaven2000
    OwnerAuthor

    Next version - there were still some problems with selecting multiple categories and proper recovering from deleted categories. This version does some sanity checking when selecting a tab and removes invalid categories from the tabInfo object - it will switch the tab back to view all categories if none of the categories exist anymore.

    QuickFolders-mx-5.11pre92.zip

    To install this version please download the zip file and drag it into Thunderbird Add-ons Manager (without unpacking)

  8. RealRaven2000 commented on Jul 20, 2022

    @RealRaven2000
    OwnerAuthor

    With the help of a user's profile I managed to remove one more problem when starting up that would still lead to no category (and not __ALL) selected resulting in no visible tab:

    QuickFolders-mx-5.11pre93.zip

    To install this version please download the zip file and drag it into Thunderbird Add-ons Manager (without unpacking)

  9. added a commit that references this issue on Jul 20, 2022
  10. RealRaven2000 commented on Jul 23, 2022

    @RealRaven2000
    OwnerAuthor

    Implemented in 5.11 - Published 23/07/2022

  11. unpinned this issue on Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions