refactor!: expect the full program as an argument, not just the type checker #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RebeccaStevens
added
the
Breaking Change
RebeccaStevens
changed the title
Codecov Report
@@ Coverage Diff @@
## next #104 +/- ##
=======================================
Coverage ? 98.02%
=======================================
Files ? 6
Lines ? 911
Branches ? 143
=======================================
Hits ? 893
Misses ? 16
Partials ? 2 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
RebeccaStevens
force-pushed
the
use-program
branch
from
41f26d8
to
55e1528
Compare
RebeccaStevens
added a commit
that referenced
this pull request
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having access to the
Programgives us more info that justChecker.We're not currently using this extra information, but it is there if we need it in future.
The new utils coming in
@typescript-eslint/type-utilsv6 that we want to leverage (re #47) will need the full Program.