This repository has been archived by the owner on Feb 18, 2022. It is now read-only.
Add global styles + base for form page #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szhu
approved these changes
Mar 28, 2020
src/styles.ts
Outdated
| @@ -0,0 +1,101 @@ | |||
| import { createGlobalStyle } from "styled-components"; | |||
There was a problem hiding this comment.
can we name all our files .tsx? This avoids situations where we rename a file .ts -> .tsx after we realize we need to put jsx in it.
also, the linters that are set up are currently only checking .tsx files. alternatively we can just add .ts patterns.
Merged
szhu
reviewed
Mar 30, 2020
Comment on lines
+4
to
+6
| @import url('https://fonts.googleapis.com/css?family=Poppins&display=swap'); | ||
| @import url('https://fonts.googleapis.com/css?family=Libre+Baskerville&display=swap'); | ||
| @import url('https://fonts.googleapis.com/css?family=Rubik&display=swap'); |
There was a problem hiding this comment.
Creating #10 to remove this because we realized it didn't work, and because styled-components gives a warning about not doing this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Global Styles & Form
This PR:
/testpage for each css styleStyles
The styles are the following:
We can update them as we build out the real pages! 馃槃