Conversation
@szhu given that |
@macfarlandian Hmm… it looks like we can just use a pre-compiled version. Thanks! This PR's diff is way smaller now! |
e759bb5
to
e2b32b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems mostly fine ... a few minor things broke but they are all things I am going to change anyway so I think this is good to merge! Thanks for taking care of this
@macfarlandian the js files are fixed! They are now complied through the Parcel pipeline rather than included verbatim. Saving JS files should no longer cause errors, but note that since they are still not aware of the React lifecycle, you'll need to reload the page to see most updates. |
This adds the overview page over from v1!
@macfarlandian please read these important notes:
bin/parcel serve index.html
and going to http://localhost:1234/overviewyarn dev
after Add form page and development scripts #3 is merged!/overview
, but I can change the URL if you have an opinion.src/index.html
->src/page-overview/OverviewPage.tsx
src/style.css
-> Alsosrc/page-overview/OverviewPage.tsx
! (Check the top of the file)src/page-overview/assets/output.css_
src/*.js
->src/page-overview/assets/*.js_
(the nonstandard file extension tells Parcel to not preprocess the file)src/icons/*
->src/page-overview/assets/icons/*
yarn build
as usual. I tested it and I think it works perfectly.Things that are hacky that we should eventually migrate off of:
(1) not use global variablesupdate: this is done! and (2) to be aware of the React lifecycle. Note: Currently your v0 overview page JS is run on all pages, not just the overview page!